third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h - Issue 2089593002: Add expansion of shorthands with custom properties to longhands using a pending substition value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h

Issue 2089593002: Add expansion of shorthands with custom properties to longhands using a pending substition value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix serialization and temporary property value caching. Add some additional tests. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/StylePropertySerializer.cpp ('K') | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp » ('j') | third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h

diff --git a/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h b/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h

index c1150ff78c650a1d38e2993b4207ff1ef9e6a59a..ae9625d067df2b0ca208782ff8497a38391c8a97 100644

--- a/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h

+++ b/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h

@@ -14,6 +14,7 @@

namespace blink {

class CSSParserTokenRange;

+class CSSPendingSubstitutionValue;

class CSSVariableData;

class CSSVariableReferenceValue;

class StyleResolverState;

@@ -22,7 +23,8 @@ class StyleVariableData;

class CSSVariableResolver {

public:

static void resolveVariableDefinitions(StyleVariableData*);

- static void resolveAndApplyVariableReferences(StyleResolverState&, CSSPropertyID, const CSSVariableReferenceValue&);

+ static const CSSValue* resolveVariableReferences(StyleResolverState&, CSSPropertyID, const CSSVariableReferenceValue&);

+ static const CSSValue* resolvePendingSubstitutions(StyleResolverState&, CSSPropertyID, const CSSPendingSubstitutionValue&);

// Shorthand properties are not supported.

static CSSValue* resolveVariableReferences(StyleVariableData*, CSSPropertyID, const CSSVariableReferenceValue&);