third_party/WebKit/Source/core/css/CSSValue.h - Issue 2089593002: Add expansion of shorthands with custom properties to longhands using a pending substition value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSValue.h

Issue 2089593002: Add expansion of shorthands with custom properties to longhands using a pending substition value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix serialization and temporary property value caching. Add some additional tests. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/css/variables/longhand-pending-shorthand-substitution.html ('K') | « third_party/WebKit/Source/core/css/CSSPendingSubstitutionValue.cpp ('k') | third_party/WebKit/Source/core/css/CSSValue.cpp » ('j') | third_party/WebKit/Source/core/css/StylePropertySerializer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSValue.h

diff --git a/third_party/WebKit/Source/core/css/CSSValue.h b/third_party/WebKit/Source/core/css/CSSValue.h

index 05d37db4f740422e1eb9980a24da78c75394057b..25b465ef45817ea767be2e0b40a0a33d4b629dae 100644

--- a/third_party/WebKit/Source/core/css/CSSValue.h

+++ b/third_party/WebKit/Source/core/css/CSSValue.h

@@ -98,6 +98,7 @@ public:

bool isCustomPropertyDeclaration() const { return m_classType == CustomPropertyDeclarationClass; }

bool isVariableReferenceValue() const { return m_classType == VariableReferenceClass; }

bool isGridAutoRepeatValue() const { return m_classType == GridAutoRepeatClass; }

+ bool isPendingSubstitutionValue() const { return m_classType == PendingSubstitutionValueClass; }

bool hasFailedOrCanceledSubresources() const;

@@ -163,6 +164,7 @@ protected:

PathClass,

VariableReferenceClass,

CustomPropertyDeclarationClass,

+ PendingSubstitutionValueClass,

// SVG classes.

CSSSVGDocumentClass,