Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2089563002: [Polymer] update polymer (Closed)

Created:
4 years, 6 months ago by dschuyler
Modified:
4 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, asanka, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Polymer] update polymer See components_summary.txt for versioning details. NOPRESUBMIT=true # crisper.js BUG=609318 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552 Cr-Commit-Position: refs/heads/master@{#401718}

Patch Set 1 #

Total comments: 1

Patch Set 2 : update polymer #

Patch Set 3 : polymer update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -232 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheBootReceiver.java View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java View 1 2 7 chunks +18 lines, -30 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheTaskScheduler.java View 1 2 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java View 1 2 4 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/crisper.js View 1 2 18 chunks +79 lines, -37 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 7 chunks +20 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/bower.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/iron-a11y-keys-behavior-extracted.js View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-fit-behavior/bower.json View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-fit-behavior/iron-fit-behavior-extracted.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/bower.json View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/iron-list.html View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/iron-list-extracted.js View 5 chunks +43 lines, -13 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/bower.json View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-pages/bower.json View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-icon-button/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-icon-button/paper-icon-button.html View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-icon-button/paper-icon-button-light.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/bower.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input.html View 1 2 chunks +5 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-behavior-extracted.js View 1 1 chunk +1 line, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-char-counter.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-char-counter-extracted.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-container.html View 1 2 chunks +5 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-textarea.html View 1 1 chunk +5 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-ripple/bower.json View 1 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple.html View 3 chunks +2 lines, -10 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple-extracted.js View 1 6 chunks +26 lines, -17 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toolbar/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toolbar/paper-toolbar.html View 5 chunks +12 lines, -8 lines 0 comments Download
M third_party/polymer/v1_0/components_summary.txt View 1 2 7 chunks +33 lines, -33 lines 0 comments Download

Messages

Total messages: 34 (14 generated)
dschuyler
(I modeled the CL comments on CL 2074813002). Thinks I've *lightly* checked so far: - ...
4 years, 6 months ago (2016-06-21 01:05:34 UTC) #3
michaelpg
On 2016/06/21 01:05:34, dschuyler wrote: > (I modeled the CL comments on CL 2074813002). > ...
4 years, 6 months ago (2016-06-21 01:08:45 UTC) #4
dschuyler
On 2016/06/21 01:08:45, michaelpg wrote: > On 2016/06/21 01:05:34, dschuyler wrote: > > (I modeled ...
4 years, 6 months ago (2016-06-21 01:11:59 UTC) #5
dschuyler
On 2016/06/21 01:11:59, dschuyler wrote: > On 2016/06/21 01:08:45, michaelpg wrote: > > On 2016/06/21 ...
4 years, 6 months ago (2016-06-21 01:12:28 UTC) #6
Dan Beam
https://codereview.chromium.org/2089563002/diff/1/third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple-extracted.js File third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple-extracted.js (right): https://codereview.chromium.org/2089563002/diff/1/third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple-extracted.js#newcode421 third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple-extracted.js:421: this.listen(this.keyEventTarget, 'up', 'uiUpAction'); this breaks closure: https://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/618/steps/compile/logs/stdio
4 years, 6 months ago (2016-06-21 01:44:55 UTC) #7
dschuyler
The Polymer update now closure compiles.
4 years, 6 months ago (2016-06-23 18:17:39 UTC) #8
Dan Beam
lgtm
4 years, 6 months ago (2016-06-23 19:23:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089563002/20001
4 years, 6 months ago (2016-06-23 20:33:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/206149)
4 years, 6 months ago (2016-06-23 20:43:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089563002/20001
4 years, 6 months ago (2016-06-23 20:48:30 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/206176)
4 years, 6 months ago (2016-06-23 20:58:31 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089563002/20001
4 years, 6 months ago (2016-06-23 21:07:08 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089563002/20001
4 years, 6 months ago (2016-06-23 21:19:47 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-23 21:22:45 UTC) #27
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552 Cr-Commit-Position: refs/heads/master@{#401718}
4 years, 6 months ago (2016-06-23 21:24:10 UTC) #29
dgozman
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2096903002/ by dgozman@chromium.org. ...
4 years, 6 months ago (2016-06-23 22:49:23 UTC) #30
Dan Beam
[25231:25231:0623/145400:INFO:CONSOLE(410)] "Uncaught TypeError: Cannot read property 'removeEventListener' of null", source: chrome://resources/polymer/v1_0/iron-a11y-keys-behavior/iron-a11y-keys-behavior-extracted.js (410) OOPS
4 years, 6 months ago (2016-06-23 22:59:04 UTC) #31
dschuyler
On 2016/06/23 22:59:04, Dan Beam wrote: > [25231:25231:0623/145400:INFO:CONSOLE(410)] "Uncaught TypeError: Cannot read > property 'removeEventListener' ...
4 years, 6 months ago (2016-06-24 00:57:01 UTC) #32
Dan Beam
On 2016/06/24 00:57:01, dschuyler wrote: > On 2016/06/23 22:59:04, Dan Beam wrote: > > [25231:25231:0623/145400:INFO:CONSOLE(410)] ...
4 years, 6 months ago (2016-06-25 00:41:37 UTC) #33
dschuyler
4 years, 6 months ago (2016-06-25 00:59:59 UTC) #34
Message was sent while issue was closed.
On 2016/06/25 00:41:37, Dan Beam wrote:
> On 2016/06/24 00:57:01, dschuyler wrote:
> > On 2016/06/23 22:59:04, Dan Beam wrote:
> > > [25231:25231:0623/145400:INFO:CONSOLE(410)] "Uncaught TypeError: Cannot
read
> > > property 'removeEventListener' of null", source:
> > >
> >
>
chrome://resources/polymer/v1_0/iron-a11y-keys-behavior/iron-a11y-keys-behavior-extracted.js
> > > (410)
> > > 
> > > OOPS
> > 
> > PR to fix at
> https://github.com/PolymerElements/iron-a11y-keys-behavior/pull/48
> 
> can we re-roll now?

re-roll in
https://codereview.chromium.org/2092213003/

Powered by Google App Engine
This is Rietveld 408576698