Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2089543002: MD Settings: remove accidentally left " from sync disconnect dialog (Closed)

Created:
4 years, 6 months ago by Dan Beam
Modified:
4 years, 6 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: remove accidentally left " from sync disconnect dialog TBR=dschuyler@chromium.org BUG=621429 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation NOTRY=true Committed: https://crrev.com/448f1a611665ac32d8521e4b5e4252159a4a6afe Cr-Commit-Position: refs/heads/master@{#400851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/people_page/people_page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Dan Beam
4 years, 6 months ago (2016-06-21 00:23:12 UTC) #2
dschuyler
lgtm
4 years, 6 months ago (2016-06-21 00:23:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089543002/1
4 years, 6 months ago (2016-06-21 00:24:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 00:28:33 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 00:30:47 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/448f1a611665ac32d8521e4b5e4252159a4a6afe
Cr-Commit-Position: refs/heads/master@{#400851}

Powered by Google App Engine
This is Rietveld 408576698