Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: go/src/infra/appengine/sheriff-o-matic/elements/som-app.html

Issue 2089493002: SOM: Fix key bug (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="/bower_components/polymer/polymer.html"> 1 <link rel="import" href="/bower_components/polymer/polymer.html">
2 <link rel="import" href="/bower_components/iron-ajax/iron-ajax.html"> 2 <link rel="import" href="/bower_components/iron-ajax/iron-ajax.html">
3 <link rel="import" href="/bower_components/iron-flex-layout/classes/iron-flex-la yout.html"> 3 <link rel="import" href="/bower_components/iron-flex-layout/classes/iron-flex-la yout.html">
4 <link rel="import" href="/bower_components/iron-icons/hardware-icons.html"> 4 <link rel="import" href="/bower_components/iron-icons/hardware-icons.html">
5 <link rel="import" href="/bower_components/iron-icon/iron-icon.html"> 5 <link rel="import" href="/bower_components/iron-icon/iron-icon.html">
6 <link rel="import" href="/bower_components/iron-icons/iron-icons.html"> 6 <link rel="import" href="/bower_components/iron-icons/iron-icons.html">
7 <link rel="import" href="/bower_components/iron-location/iron-location.html"> 7 <link rel="import" href="/bower_components/iron-location/iron-location.html">
8 <link rel="import" href="/bower_components/iron-pages/iron-pages.html"> 8 <link rel="import" href="/bower_components/iron-pages/iron-pages.html">
9 <link rel="import" href="/bower_components/neon-animation/animations/scale-up-an imation.html"> 9 <link rel="import" href="/bower_components/neon-animation/animations/scale-up-an imation.html">
10 <link rel="import" href="/bower_components/neon-animation/animations/fade-out-an imation.html"> 10 <link rel="import" href="/bower_components/neon-animation/animations/fade-out-an imation.html">
(...skipping 470 matching lines...) Expand 10 before | Expand all | Expand 10 after
481 this.annotationsJson = newArray; 481 this.annotationsJson = newArray;
482 }, 482 },
483 483
484 _sendAnnotation: function(key, type, change) { 484 _sendAnnotation: function(key, type, change) {
485 this.$.annotationPost.body = JSON.stringify(change); 485 this.$.annotationPost.body = JSON.stringify(change);
486 this.$.annotationPost.url = '/api/v1/annotations/' + key + '/' + type; 486 this.$.annotationPost.url = '/api/v1/annotations/' + key + '/' + type;
487 this.$.annotationPost.generateRequest(); 487 this.$.annotationPost.generateRequest();
488 }, 488 },
489 489
490 _keyForAlert: function(alert) { 490 _keyForAlert: function(alert) {
491 if (alert.extension && alert.extension.reasons && 491 if (alert.key) {
492 return alert.key;
493 } else if (alert.extension && alert.extension.reasons &&
seanmccullough1 2016/06/20 23:28:02 ok I see. Is it okay to just use alert.key instead
492 alert.extension.builders) { 494 alert.extension.builders) {
493 return alert.extension.reasons.map(function(reason) { 495 return alert.extension.reasons.map(function(reason) {
494 return reason.step; 496 return reason.step;
495 }).concat(alert.extension.builders.map(function(builder) { 497 }).concat(alert.extension.builders.map(function(builder) {
496 return builder.name; 498 return builder.name;
497 })).join('::'); 499 })).join('::');
498 } 500 }
499 return null; 501 return null;
500 }, 502 },
501 503
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
539 this._sendAnnotation( 541 this._sendAnnotation(
540 this._keyForAlert(this._snoozeModel), 'add', { 542 this._keyForAlert(this._snoozeModel), 'add', {
541 snoozeTime: Date.now() + ONE_MIN_MS * this.$.snoozeTime.value 543 snoozeTime: Date.now() + ONE_MIN_MS * this.$.snoozeTime.value
542 }); 544 });
543 }, 545 },
544 546
545 }); 547 });
546 })(); 548 })();
547 </script> 549 </script>
548 </dom-module> 550 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698