xfa/fxfa/include/xfa_ffwidgethandler.h - Issue 2089443002: Convert XFA_ELEMENT to an enum class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/include/xfa_ffwidgethandler.h

Issue 2089443002: Convert XFA_ELEMENT to an enum class (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: More unknown checks Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fxfa/include/xfa_ffwidgethandler.h

diff --git a/xfa/fxfa/include/xfa_ffwidgethandler.h b/xfa/fxfa/include/xfa_ffwidgethandler.h

index cc6d04861929744d3bae21a84c00aebab7681c82..4aa86d21f0a09ffaa09f91554c8ccdf421d9463f 100644

--- a/xfa/fxfa/include/xfa_ffwidgethandler.h

+++ b/xfa/fxfa/include/xfa_ffwidgethandler.h

@@ -93,7 +93,7 @@ class CXFA_FFWidgetHandler {

CXFA_Node* CreateListBox(CXFA_Node* pParent, CXFA_Node* pBefore) const;

CXFA_Node* CreateImageField(CXFA_Node* pParent, CXFA_Node* pBefore) const;

CXFA_Node* CreatePasswordEdit(CXFA_Node* pParent, CXFA_Node* pBefore) const;

- CXFA_Node* CreateField(XFA_ELEMENT eElement,

+ CXFA_Node* CreateField(XFA_Element eElement,

CXFA_Node* pParent,

CXFA_Node* pBefore) const;

CXFA_Node* CreateArc(CXFA_Node* pParent, CXFA_Node* pBefore) const;

@@ -101,25 +101,25 @@ class CXFA_FFWidgetHandler {

CXFA_Node* CreateImage(CXFA_Node* pParent, CXFA_Node* pBefore) const;

CXFA_Node* CreateLine(CXFA_Node* pParent, CXFA_Node* pBefore) const;

CXFA_Node* CreateText(CXFA_Node* pParent, CXFA_Node* pBefore) const;

- CXFA_Node* CreateDraw(XFA_ELEMENT eElement,

+ CXFA_Node* CreateDraw(XFA_Element eElement,

CXFA_Node* pParent,

CXFA_Node* pBefore) const;

CXFA_Node* CreateSubform(CXFA_Node* pParent, CXFA_Node* pBefore) const;

- CXFA_Node* CreateFormItem(XFA_ELEMENT eElement,

+ CXFA_Node* CreateFormItem(XFA_Element eElement,

CXFA_Node* pParent,

CXFA_Node* pBefore) const;

- CXFA_Node* CreateCopyNode(XFA_ELEMENT eElement,

+ CXFA_Node* CreateCopyNode(XFA_Element eElement,

CXFA_Node* pParent,

CXFA_Node* pBefore = NULL) const;

- CXFA_Node* CreateTemplateNode(XFA_ELEMENT eElement,

+ CXFA_Node* CreateTemplateNode(XFA_Element eElement,

CXFA_Node* pParent,

CXFA_Node* pBefore) const;

CXFA_Node* CreateFontNode(CXFA_Node* pParent) const;

CXFA_Node* CreateMarginNode(CXFA_Node* pParent,

uint32_t dwFlags,

FX_FLOAT fInsets[4]) const;

- CXFA_Node* CreateValueNode(XFA_ELEMENT eValue, CXFA_Node* pParent) const;

+ CXFA_Node* CreateValueNode(XFA_Element eValue, CXFA_Node* pParent) const;

CXFA_Document* GetObjFactory() const;

CXFA_Document* GetXFADoc() const;

« no previous file with comments | « xfa/fxfa/include/xfa_ffwidget.h ('k') | xfa/fxfa/parser/cxfa_assist.cpp » ('j') | no next file with comments »