xfa/fxfa/app/xfa_ffdochandler.cpp - Issue 2089443002: Convert XFA_ELEMENT to an enum class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_ffdochandler.cpp

Issue 2089443002: Convert XFA_ELEMENT to an enum class (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: review cleanup Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/app/xfa_ffdochandler.cpp

diff --git a/xfa/fxfa/app/xfa_ffdochandler.cpp b/xfa/fxfa/app/xfa_ffdochandler.cpp

index 38e872a0432b4208fd21447911ee683f8ce24d5e..e0a28337ca05a87b226515a516d8807abaa246f4 100644

--- a/xfa/fxfa/app/xfa_ffdochandler.cpp

+++ b/xfa/fxfa/app/xfa_ffdochandler.cpp

@@ -35,7 +35,7 @@ XFA_ATTRIBUTEENUM CXFA_FFDocHandler::GetRestoreState(CXFA_FFDoc* hDoc) {

if (!pForm)

return XFA_ATTRIBUTEENUM_Unknown;

- CXFA_Node* pSubForm = pForm->GetFirstChildByClass(XFA_ELEMENT_Subform);

+ CXFA_Node* pSubForm = pForm->GetFirstChildByClass(XFA_Element::Subform);

if (!pSubForm)

return XFA_ATTRIBUTEENUM_Unknown;

return pSubForm->GetEnum(XFA_ATTRIBUTE_RestoreState);