Convert XFA_ELEMENT to an enum class

xfa/fxfa/parser/xfa_script_nodehelper.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/parser/xfa_script_nodehelper.h"
 
 #include "core/fxcrt/include/fx_ext.h"
 #include "xfa/fxfa/parser/xfa_doclayout.h"
 #include "xfa/fxfa/parser/xfa_document.h"
 #include "xfa/fxfa/parser/xfa_localemgr.h"
 #include "xfa/fxfa/parser/xfa_object.h"
 #include "xfa/fxfa/parser/xfa_parser.h"
 #include "xfa/fxfa/parser/xfa_script.h"
 #include "xfa/fxfa/parser/xfa_script_imp.h"
 #include "xfa/fxfa/parser/xfa_utils.h"
 
 CXFA_NodeHelper::CXFA_NodeHelper()
-    : m_eLastCreateType(XFA_ELEMENT_DataValue),
+    : m_eLastCreateType(XFA_Element::DataValue),
       m_pCreateParent(NULL),
       m_iCreateCount(0),
       m_iCreateFlag(XFA_RESOLVENODE_RSTYPE_CreateNodeOne),
       m_iCurAllStart(-1),
       m_pAllStartParent(NULL) {}
 
 CXFA_NodeHelper::~CXFA_NodeHelper() {}
 
 CXFA_Node* CXFA_NodeHelper::XFA_ResolveNodes_GetOneChild(
     CXFA_Node* parent,
@@ skipping 116 matching lines @@
     int32_t nProperties = properties.GetSize();
     for (i = 0; i < nProperties; ++i) {
       CXFA_Node* child = properties[i];
       if (bIsClassName) {
         if (child->GetClassHashCode() == dNameHash) {
           pSiblings->Add(child);
           nCount++;
         }
       } else {
         if (child->GetNameHash() == dNameHash) {
-          if (child->GetClassID() != XFA_ELEMENT_PageSet &&
-              child->GetClassID() != XFA_ELEMENT_Extras &&
-              child->GetClassID() != XFA_ELEMENT_Items) {
+          if (child->GetClassID() != XFA_Element::PageSet &&
+              child->GetClassID() != XFA_Element::Extras &&
+              child->GetClassID() != XFA_Element::Items) {
             pSiblings->Add(child);
             nCount++;
           }
         }
       }
-      if (child->IsUnnamed() && child->GetClassID() == XFA_ELEMENT_PageSet) {
+      if (child->IsUnnamed() && child->GetClassID() == XFA_Element::PageSet) {
         nCount += XFA_NodeAcc_TraverseSiblings(child, dNameHash, pSiblings,
                                                eLogicType, bIsClassName, FALSE);
       }
     }
     if (nCount > 0) {
       return nCount;
     }
   }
   CXFA_NodeArray children;
   parent->GetNodeList(children, XFA_NODEFILTER_Children);
   int32_t nChildren = children.GetSize();
   for (i = 0; i < nChildren; i++) {
     CXFA_Node* child = children[i];
-    if (child->GetClassID() == XFA_ELEMENT_Variables) {
+    if (child->GetClassID() == XFA_Element::Variables) {
       continue;
     }
     if (bIsClassName) {
       if (child->GetClassHashCode() == dNameHash) {
         if (pSiblings) {
           pSiblings->Add(child);
         }
         nCount++;
       }
     } else {
       if (child->GetNameHash() == dNameHash) {
         if (pSiblings) {
           pSiblings->Add(child);
         }
         nCount++;
       }
     }
     if (eLogicType == XFA_LOGIC_NoTransparent) {
       continue;
     }
     if (XFA_NodeIsTransparent(child) &&
-        child->GetClassID() != XFA_ELEMENT_PageSet) {
+        child->GetClassID() != XFA_Element::PageSet) {
       nCount += XFA_NodeAcc_TraverseSiblings(child, dNameHash, pSiblings,
                                              eLogicType, bIsClassName, FALSE);
     }
   }
   return nCount;
 }
 
 CXFA_Node* CXFA_NodeHelper::XFA_ResolveNodes_GetParent(
     CXFA_Node* pNode,
     XFA_LOGIC_TYPE eLogicType) {
   if (!pNode) {
     return NULL;
   }
   if (eLogicType == XFA_LOGIC_NoTransparent) {
     return pNode->GetNodeItem(XFA_NODEITEM_Parent);
   }
   CXFA_Node* parent;
   CXFA_Node* node = pNode;
   while (TRUE) {
     parent = XFA_ResolveNodes_GetParent(node);
     if (parent == NULL) {
       break;
     }
-    XFA_ELEMENT parentElement = parent->GetClassID();
-    if ((!parent->IsUnnamed() && parentElement != XFA_ELEMENT_SubformSet) ||
-        parentElement == XFA_ELEMENT_Variables) {
+    XFA_Element parentElement = parent->GetClassID();
+    if ((!parent->IsUnnamed() && parentElement != XFA_Element::SubformSet) ||
+        parentElement == XFA_Element::Variables) {
       break;
     }
     node = parent;
   }
   return parent;
 }
 
 int32_t CXFA_NodeHelper::XFA_GetIndex(CXFA_Node* pNode,
                                       XFA_LOGIC_TYPE eLogicType,
                                       FX_BOOL bIsProperty,
@@ skipping 42 matching lines @@
       wsName = wsParent;
       parent = XFA_ResolveNodes_GetParent(parent, XFA_LOGIC_NoTransparent);
     }
     return;
   }
 
   CFX_WideStringC wsTagName;
   CFX_WideString ws;
   FX_BOOL bIsProperty = XFA_NodeIsProperty(refNode);
   if (refNode->IsUnnamed() ||
-      (bIsProperty && refNode->GetClassID() != XFA_ELEMENT_PageSet)) {
+      (bIsProperty && refNode->GetClassID() != XFA_Element::PageSet)) {
     refNode->GetClassName(wsTagName);
     ws = wsTagName;
     wsName.Format(L"#%s[%d]", ws.c_str(),
                   XFA_GetIndex(refNode, eLogicType, bIsProperty, TRUE));
     return;
   }
   ws = refNode->GetCData(XFA_ATTRIBUTE_Name);
   ws.Replace(L".", L"\\.");
   wsName.Format(L"%s[%d]", ws.c_str(),
                 XFA_GetIndex(refNode, eLogicType, bIsProperty, FALSE));
 }
 
 FX_BOOL CXFA_NodeHelper::XFA_NodeIsTransparent(CXFA_Node* refNode) {
   if (refNode == NULL) {
     return FALSE;
   }
-  XFA_ELEMENT eRefNode = refNode->GetClassID();
+  XFA_Element eRefNode = refNode->GetClassID();
   if ((refNode->IsUnnamed() && refNode->IsContainerNode()) ||
-      eRefNode == XFA_ELEMENT_SubformSet || eRefNode == XFA_ELEMENT_Area ||
-      eRefNode == XFA_ELEMENT_Proto) {
+      eRefNode == XFA_Element::SubformSet || eRefNode == XFA_Element::Area ||
+      eRefNode == XFA_Element::Proto) {
     return TRUE;
   }
   return FALSE;
 }
 
 FX_BOOL CXFA_NodeHelper::XFA_CreateNode_ForCondition(
     CFX_WideString& wsCondition) {
   int32_t iLen = wsCondition.GetLength();
   CFX_WideString wsIndex(L"0");
   FX_BOOL bAll = FALSE;
@@ skipping 63 matching lines @@
           m_pCreateParent->CreateSamePacketNode(lpElement->eName);
       if (pNewNode) {
         m_pCreateParent->InsertChild(pNewNode);
         if (iIndex == m_iCreateCount - 1) {
           m_pCreateParent = pNewNode;
         }
         bResult = TRUE;
       }
     }
   } else {
-    XFA_ELEMENT eClassType = XFA_ELEMENT_DataGroup;
+    XFA_Element eClassType = XFA_Element::DataGroup;
     if (bLastNode) {
       eClassType = m_eLastCreateType;
     }
     for (int32_t iIndex = 0; iIndex < m_iCreateCount; iIndex++) {
       CXFA_Node* pNewNode = m_pCreateParent->CreateSamePacketNode(eClassType);
       if (pNewNode) {
         pNewNode->SetAttribute(XFA_ATTRIBUTE_Name, wsName.AsStringC());
         pNewNode->CreateXMLMappingNode();
         m_pCreateParent->InsertChild(pNewNode);
         if (iIndex == m_iCreateCount - 1) {
           m_pCreateParent = pNewNode;
         }
         bResult = TRUE;
       }
     }
   }
   if (!bResult) {
     m_pCreateParent = NULL;
   }
   return bResult;
 }
 
 void CXFA_NodeHelper::XFA_SetCreateNodeType(CXFA_Node* refNode) {
   if (refNode == NULL) {
     return;
   }
-  if (refNode->GetClassID() == XFA_ELEMENT_Subform) {
-    m_eLastCreateType = XFA_ELEMENT_DataGroup;
-  } else if (refNode->GetClassID() == XFA_ELEMENT_Field) {
+  if (refNode->GetClassID() == XFA_Element::Subform) {
+    m_eLastCreateType = XFA_Element::DataGroup;
+  } else if (refNode->GetClassID() == XFA_Element::Field) {
     m_eLastCreateType = XFA_FieldIsMultiListBox(refNode)
-                            ? XFA_ELEMENT_DataGroup
-                            : XFA_ELEMENT_DataValue;
-  } else if (refNode->GetClassID() == XFA_ELEMENT_ExclGroup) {
-    m_eLastCreateType = XFA_ELEMENT_DataValue;
+                            ? XFA_Element::DataGroup
+                            : XFA_Element::DataValue;
+  } else if (refNode->GetClassID() == XFA_Element::ExclGroup) {
+    m_eLastCreateType = XFA_Element::DataValue;
   }
 }
 
 FX_BOOL CXFA_NodeHelper::XFA_NodeIsProperty(CXFA_Node* refNode) {
   CXFA_Node* parent =
       XFA_ResolveNodes_GetParent(refNode, XFA_LOGIC_NoTransparent);
   return parent && refNode &&
          XFA_GetPropertyOfElement(parent->GetClassID(), refNode->GetClassID(),
                                   XFA_XDPPACKET_UNKNOWN);
 }