Refactors getting available color profiles code.

Refactors getting available color profiles code.

My first CL got affected the recent refactoring of display/chromeos
and it needs some cleanups. I think the new code makes more sense.
- DisplayState struct isn't accessible from native_display_delegate
  but the color profiles are in the native layer. It doesn't make
  sense to put the list there.
- Instead of moving the data into DisplaySnapshot, it seems nicer
  to query the list of available profiles and to treat the list
  as a cache. This also avoids duplicating the same list both in
  DisplayInfo and another struct.
- The destructor of DisplayState was introduced by me because
  it gets a complicated struct due to available_color_profiles.
  Now it's gone, so it doesn't necessarily exist.

BUG=None
R=oshima@chromium.org, marcheu@chromium.org
TEST=build succeeds

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258798

[oshima, 2014-03-21 23:37:10]

https://codereview.chromium.org/208943002/diff/1/ash/display/display_change_o...
File ash/display/display_change_observer_chromeos.cc (right):

https://codereview.chromium.org/208943002/diff/1/ash/display/display_change_o...
ash/display/display_change_observer_chromeos.cc:160:
displays.push_back(DisplayInfo(id, name, has_overscan));
The list is getting longer. Can you get the reference to the end of the
DisplayInfo and use it instead of "back()"?

https://codereview.chromium.org/208943002/diff/1/ui/display/chromeos/native_d...
File ui/display/chromeos/native_display_delegate.h (right):

https://codereview.chromium.org/208943002/diff/1/ui/display/chromeos/native_d...
ui/display/chromeos/native_display_delegate.h:79:
std::vector<ui::ColorCalibrationProfile>* profiles) = 0;
just return std::vector<ui::ColorCalibrationProfile> instead of
using out parameter. It's more readable and performance should be the same (RVO)

[Jun Mukai, 2014-03-22 00:20:29]

https://codereview.chromium.org/208943002/diff/1/ash/display/display_change_o...
File ash/display/display_change_observer_chromeos.cc (right):

https://codereview.chromium.org/208943002/diff/1/ash/display/display_change_o...
ash/display/display_change_observer_chromeos.cc:160:
displays.push_back(DisplayInfo(id, name, has_overscan));
On 2014/03/21 23:37:10, oshima wrote:
> The list is getting longer. Can you get the reference to the end of the
> DisplayInfo and use it instead of "back()"?

Done.

https://codereview.chromium.org/208943002/diff/1/ui/display/chromeos/native_d...
File ui/display/chromeos/native_display_delegate.h (right):

https://codereview.chromium.org/208943002/diff/1/ui/display/chromeos/native_d...
ui/display/chromeos/native_display_delegate.h:79:
std::vector<ui::ColorCalibrationProfile>* profiles) = 0;
On 2014/03/21 23:37:10, oshima wrote:
> just return std::vector<ui::ColorCalibrationProfile> instead of
> using out parameter. It's more readable and performance should be the same
(RVO)

Done.

[oshima, 2014-03-22 00:25:25]

lgtm

[Jun Mukai, 2014-03-22 00:36:17]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-03-22 00:38:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/208943002/10001

[commit-bot: I haz the power, 2014-03-22 07:01:53]

Change committed as 258798