Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6088)

Unified Diff: chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js

Issue 2089423002: [Offline Pages] Connect the offline page logs to the internals page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@i4
Patch Set: style update Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
diff --git a/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js b/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
index 7ab1de4f007ecd268e26c61c37d6124fc3302c5d..ab975537935f7195be387b5e6d2a2b5063470f4d 100644
--- a/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
+++ b/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
@@ -60,6 +60,25 @@ cr.define('offlineInternals', function() {
* pages are deleted.
*/
deleteSelectedPages: function(ids) {},
+
+ /**
+ * Sets whether to record logs for stored pages.
+ * @param {boolean} shouldLog True if we should enable logging.
dpapad 2016/06/24 20:33:39 Nit (optional): Avoid using 'we' in comments. "Whe
chili 2016/06/24 21:43:17 Done.
+ */
+ setRecordPageModel: function(shouldLog) {},
+
+ /**
+ * Sets whether to record logs for scheduled requests.
+ * @param {boolean} shouldLog True if we should enable logging.
+ */
+ setRecordRequestQueue: function(shouldLog) {},
+
+ /**
+ * Gets the currently recorded logs.
+ * @return {!Promise<!Array<string>>} A promise firing when the
+ * logs are retrieved.
+ */
+ getEventLogs: function() {},
};
/**
@@ -88,7 +107,22 @@ cr.define('offlineInternals', function() {
/** @override */
deleteSelectedPages: function(ids) {
return cr.sendWithPromise('deleteSelectedPages', ids);
- }
+ },
+
+ /** @override */
+ setRecordPageModel: function(shouldLog) {
+ chrome.send('setRecordPageModel');
+ },
+
+ /** @override */
+ setRecordRequestQueue: function(shouldLog) {
+ chrome.send('setRecordRequestQueue');
+ },
+
+ /** @override */
+ getEventLogs: function() {
+ return cr.sendWithPromise('getEventLogs');
+ },
};
return {

Powered by Google App Engine
This is Rietveld 408576698