Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: components/offline_pages/offline_page_model_impl.cc

Issue 2089413002: [Offline Pages] Create a event/activity logger (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl.cc
diff --git a/components/offline_pages/offline_page_model_impl.cc b/components/offline_pages/offline_page_model_impl.cc
index ad7706f07f8a828b2faf92be1b481d1ecf128f32..5561b3c314bbc733b97100ba27bdfe39397da62a 100644
--- a/components/offline_pages/offline_page_model_impl.cc
+++ b/components/offline_pages/offline_page_model_impl.cc
@@ -684,6 +684,10 @@ bool OfflinePageModelImpl::is_loaded() const {
return is_loaded_;
}
+OfflineEventLogger* OfflinePageModelImpl::GetLogger() {
+ return &offline_event_logger_;
+}
+
void OfflinePageModelImpl::OnCreateArchiveDone(const GURL& requested_url,
int64_t offline_id,
const ClientId& client_id,
@@ -728,6 +732,9 @@ void OfflinePageModelImpl::OnAddOfflinePageDone(
offline_pages_[offline_page.offline_id] = offline_page;
result = SavePageResult::SUCCESS;
ReportPageHistogramAfterSave(offline_page);
+ offline_event_logger_.RecordPageSaved(
+ offline_page.client_id.name_space, offline_page.url.spec(),
+ std::to_string(offline_page.offline_id));
} else {
result = SavePageResult::STORE_FAILURE;
}
@@ -880,6 +887,7 @@ void OfflinePageModelImpl::OnRemoveOfflinePagesDone(
ReportPageHistogramsAfterDelete(offline_pages_, offline_ids);
for (int64_t offline_id : offline_ids) {
+ offline_event_logger_.RecordPageDeleted(std::to_string(offline_id));
auto iter = offline_pages_.find(offline_id);
if (iter == offline_pages_.end())
continue;
@@ -979,6 +987,7 @@ void OfflinePageModelImpl::OnResetStoreDoneForClearAll(
bool success) {
DCHECK(success);
if (!success) {
+ offline_event_logger_.RecordStoreClearError();
UMA_HISTOGRAM_ENUMERATION("OfflinePages.ClearAllStatus2",
STORE_RESET_FAILED, CLEAR_ALL_STATUS_COUNT);
}
@@ -1000,6 +1009,12 @@ void OfflinePageModelImpl::OnReloadStoreDoneForClearAll(
: STORE_RELOAD_FAILED,
CLEAR_ALL_STATUS_COUNT);
+ if (load_status == OfflinePageMetadataStore::LOAD_SUCCEEDED) {
+ offline_event_logger_.RecordStoreCleared();
+ } else {
+ offline_event_logger_.RecordStoreReloadError();
+ }
+
CacheLoadedData(offline_pages);
callback.Run();
}
« no previous file with comments | « components/offline_pages/offline_page_model_impl.h ('k') | components/offline_pages/stub_offline_page_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698