components/offline_pages.gypi - Issue 2089413002: [Offline Pages] Create a event/activity logger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages.gypi

Issue 2089413002: [Offline Pages] Create a event/activity logger (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address initial comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/offline_pages.gypi

diff --git a/components/offline_pages.gypi b/components/offline_pages.gypi

index c3b8b7a784b0ad5bd92b5d9afc33f46368cd01d2..523d4fd83c321710d0a1ed8e16730944289cf5c6 100644

--- a/components/offline_pages.gypi

+++ b/components/offline_pages.gypi

@@ -25,6 +25,8 @@

'offline_pages/client_namespace_constants.h',

'offline_pages/client_policy_controller.cc',

'offline_pages/client_policy_controller.h',

+ 'offline_pages/offline_event_logger.cc',

+ 'offline_pages/offline_event_logger.h',

'offline_pages/offline_page_archiver.h',

'offline_pages/offline_page_client_policy.h',

'offline_pages/offline_page_feature.cc',

@@ -33,8 +35,12 @@

'offline_pages/offline_page_item.h',

'offline_pages/offline_page_metadata_store.cc',

'offline_pages/offline_page_metadata_store.h',

+ 'offline_pages/offline_page_metadata_store_sql.cc',

+ 'offline_pages/offline_page_metadata_store_sql.h',

'offline_pages/offline_page_model.cc',

'offline_pages/offline_page_model.h',

+ 'offline_pages/offline_page_model_event_logger.cc',

+ 'offline_pages/offline_page_model_event_logger.h',

'offline_pages/offline_page_model_impl.cc',

'offline_pages/offline_page_model_impl.h',

'offline_pages/offline_page_storage_manager.cc',

@@ -42,8 +48,6 @@

'offline_pages/offline_page_types.h',

'offline_pages/snapshot_controller.cc',

'offline_pages/snapshot_controller.h',

- 'offline_pages/offline_page_metadata_store_sql.cc',

- 'offline_pages/offline_page_metadata_store_sql.h',

{

@@ -68,6 +72,8 @@

'offline_pages/background/offliner_policy.h',

'offline_pages/background/request_coordinator.cc',

'offline_pages/background/request_coordinator.h',

+ 'offline_pages/background/request_coordinator_event_logger.cc',

+ 'offline_pages/background/request_coordinator_event_logger.h',

'offline_pages/background/request_picker.cc',

'offline_pages/background/request_picker.h',

'offline_pages/background/request_queue.cc',

« no previous file with comments | « components/components_tests.gyp ('k') | components/offline_pages/BUILD.gn » ('j') | components/offline_pages/background/request_coordinator.h » ('J')