[Offline Pages] Create a event/activity logger

components/offline_pages/offline_page_model_impl.cc

Index: components/offline_pages/offline_page_model_impl.cc
diff --git a/components/offline_pages/offline_page_model_impl.cc b/components/offline_pages/offline_page_model_impl.cc
index d570c4a0c53078cd9f1a48a2471325f77bcca0f2..f70755de4747df97e9829adf462454b34509a762 100644
--- a/components/offline_pages/offline_page_model_impl.cc
+++ b/components/offline_pages/offline_page_model_impl.cc
@@ -680,6 +680,14 @@ bool OfflinePageModelImpl::is_loaded() const {
   return is_loaded_;
 }
 
+void OfflinePageModelImpl::GetLogs(std::vector<std::string>& storage_vector) {

[fgorski, 2016/06/23 16:34:07]

I think a cleaner way would be to expose GetOfflineLogger method.
Please think about that.

[chili, 2016/06/24 02:45:52]

My original thought was that then people can add a bunch of activities to the
logger.  However, that was before I made a bunch of decisions so that the
assumption is no longer true.  Changed.

+  offline_event_logger_.GetLogs(storage_vector);
+}
+
+void OfflinePageModelImpl::SetIsLogging(bool should_log) {
+  offline_event_logger_.SetIsLogging(should_log);
+}
+
 void OfflinePageModelImpl::OnCreateArchiveDone(const GURL& requested_url,
                                                int64_t offline_id,
                                                const ClientId& client_id,
@@ -724,6 +732,9 @@ void OfflinePageModelImpl::OnAddOfflinePageDone(
     offline_pages_[offline_page.offline_id] = offline_page;
     result = SavePageResult::SUCCESS;
     ReportPageHistogramAfterSave(offline_page);
+    offline_event_logger_.RecordPageSaved(
+        offline_page.client_id.name_space, offline_page.url.spec(),
+        std::to_string(offline_page.offline_id));
   } else {
     result = SavePageResult::STORE_FAILURE;
   }
@@ -833,6 +844,7 @@ void OfflinePageModelImpl::OnRemoveOfflinePagesDone(
   ReportPageHistogramsAfterDelete(offline_pages_, offline_ids);
 
   for (int64_t offline_id : offline_ids) {
+    offline_event_logger_.RecordPageDeleted(std::to_string(offline_id));
     auto iter = offline_pages_.find(offline_id);
     if (iter == offline_pages_.end())
       continue;
@@ -932,6 +944,7 @@ void OfflinePageModelImpl::OnResetStoreDoneForClearAll(
     bool success) {
   DCHECK(success);
   if (!success) {
+    offline_event_logger_.RecordStoreClearError();
     UMA_HISTOGRAM_ENUMERATION("OfflinePages.ClearAllStatus2",
                               STORE_RESET_FAILED, CLEAR_ALL_STATUS_COUNT);
   }
@@ -953,6 +966,11 @@ void OfflinePageModelImpl::OnReloadStoreDoneForClearAll(
           : STORE_RELOAD_FAILED,
       CLEAR_ALL_STATUS_COUNT);
 
+  if (load_status == OfflinePageMetadataStore::LOAD_SUCCEEDED)
+    offline_event_logger_.RecordStoreCleared();
+  else
+    offline_event_logger_.RecordStoreReloadError();
+
   CacheLoadedData(offline_pages);
   callback.Run();
 }