 Chromium Code Reviews
 Chromium Code Reviews Issue 2089413002:
  [Offline Pages] Create a event/activity logger  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 2089413002:
  [Offline Pages] Create a event/activity logger  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: components/offline_pages/background/request_coordinator.h | 
| diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h | 
| index ffbb8570499257b13d5d6f8b66ab650d85d5e887..cd8b7061d54e17eefd4327c587d4431bddc4c0c7 100644 | 
| --- a/components/offline_pages/background/request_coordinator.h | 
| +++ b/components/offline_pages/background/request_coordinator.h | 
| @@ -13,6 +13,7 @@ | 
| #include "components/keyed_service/core/keyed_service.h" | 
| #include "components/offline_pages/background/device_conditions.h" | 
| #include "components/offline_pages/background/offliner.h" | 
| +#include "components/offline_pages/background/request_coordinator_event_logger.h" | 
| #include "components/offline_pages/background/request_queue.h" | 
| #include "url/gurl.h" | 
| @@ -73,6 +74,10 @@ class RequestCoordinator : public KeyedService { | 
| return last_offlining_status_; | 
| } | 
| + void SetIsLogging(bool should_log); | 
| 
fgorski
2016/06/23 16:34:06
I started review in the middle, so you might see a
 
chili
2016/06/24 02:45:50
done
 | 
| + | 
| + void GetLogs(std::vector<std::string> logs); | 
| + | 
| private: | 
| void AddRequestResultCallback(RequestQueue::AddRequestResult result, | 
| const SavePageRequest& request); | 
| @@ -110,6 +115,8 @@ class RequestCoordinator : public KeyedService { | 
| std::unique_ptr<RequestPicker> picker_; | 
| // Calling this returns to the scheduler across the JNI bridge. | 
| base::Callback<void(bool)> scheduler_callback_; | 
| + // Logger to record events. | 
| + RequestCoordinatorEventLogger event_logger_; | 
| // Allows us to pass a weak pointer to callbacks. | 
| base::WeakPtrFactory<RequestCoordinator> weak_ptr_factory_; |