infra/go: Stop extra evaluation of env.py output.

infra/go: Stop extra evaluation of env.py output.

Currently the output of env.py is quoted with double quotes. This means values
inside the string will be evaluated when doing `eval $(env.py)`.

This would mean things would go horrible wrong if you had dollar symbols,
backticks or other such special characters in your path. This was discovered by
the new PS1 tagging addition added in
https://codereview.chromium.org/2071243002/, as prompts frequently have such
syntax in them.

This changes prevents that from occurring by using single quotes. It also
escapes any single quotes which already exist in the string.

Committed: https://chromium.googlesource.com/infra/infra/+/aa0508ab31e17cf6e8310d8908d4f8ce0b2798a0

[mithro, 2016-06-23 04:19:05]

tansell@chromium.org changed reviewers:
+ maruel@chromium.org, nodir@chromium.org, vadimsh@chromium.org

[mithro, 2016-06-23 04:19:06]

Hi nodir,

This should fix the problem you discovered after I landed
https://codereview.chromium.org/2071243002/

It should also make env.py safe around special characters in other environment
values exported.

Tim 'mithro' Ansell

[mithro, 2016-06-23 04:19:15]

The CQ bit was checked by tansell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 04:19:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2089403002/1

[commit-bot: I haz the power, 2016-06-23 04:19:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 04:19:28]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[M-A Ruel, 2016-06-23 13:16:20]

lgtm

[mithro, 2016-06-23 15:23:08]

The CQ bit was checked by tansell@chromium.org

[commit-bot: I haz the power, 2016-06-23 15:23:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2089403002/1

[commit-bot: I haz the power, 2016-06-23 15:37:36]

Description was changed from

==========
infra/go: Stop extra evaluation of env.py output.

Currently the output of env.py is quoted with double quotes. This means values
inside the string will be evaluated when doing `eval $(env.py)`.

This would mean things would go horrible wrong if you had dollar symbols,
backticks or other such special characters in your path. This was discovered by
the new PS1 tagging addition added in
https://codereview.chromium.org/2071243002/, as prompts frequently have such
syntax in them.

This changes prevents that from occurring by using single quotes. It also
escapes any single quotes which already exist in the string.
==========

to

==========
infra/go: Stop extra evaluation of env.py output.

Currently the output of env.py is quoted with double quotes. This means values
inside the string will be evaluated when doing `eval $(env.py)`.

This would mean things would go horrible wrong if you had dollar symbols,
backticks or other such special characters in your path. This was discovered by
the new PS1 tagging addition added in
https://codereview.chromium.org/2071243002/, as prompts frequently have such
syntax in them.

This changes prevents that from occurring by using single quotes. It also
escapes any single quotes which already exist in the string.

Committed:
https://chromium.googlesource.com/infra/infra/+/aa0508ab31e17cf6e8310d8908d4f...
==========

[commit-bot: I haz the power, 2016-06-23 15:37:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/aa0508ab31e17cf6e8310d8908d4f...

[nodir, 2016-06-23 18:58:15]

thanks, this fixed my problem