Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2089393002: Don't bypass safepoint check when background finalizer task enters the isolate. (Closed)

Created:
4 years, 6 months ago by rmacnak
Modified:
4 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't bypass safepoint check when background finalizer task enters the isolate. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/a871dbc57c9debee1ef448b6bdd0b4584664dd79

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M runtime/vm/dart_api_state.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 6 months ago (2016-06-23 01:05:33 UTC) #2
siva
lgtm
4 years, 6 months ago (2016-06-23 01:20:30 UTC) #3
rmacnak
4 years, 6 months ago (2016-06-23 01:22:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a871dbc57c9debee1ef448b6bdd0b4584664dd79 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698