Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: components/crash/content/app/breakpad_linux.cc

Issue 2089343002: Added gms version as key value pair. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/content/app/breakpad_linux.cc
diff --git a/components/crash/content/app/breakpad_linux.cc b/components/crash/content/app/breakpad_linux.cc
index 30ae96b6878cb7e7f1158761a5055e10bcc58fd8..c3a01a9922496fa889dd47e0f2315ea71f8654ff 100644
--- a/components/crash/content/app/breakpad_linux.cc
+++ b/components/crash/content/app/breakpad_linux.cc
@@ -603,10 +603,6 @@ bool FinalizeCrashDoneAndroid(bool is_browser_process) {
android_build_info->package_version_name());
__android_log_write(ANDROID_LOG_WARN, kGoogleBreakpad,
android_build_info->package_version_code());
- __android_log_write(ANDROID_LOG_WARN, kGoogleBreakpad,
- "Google Play services app version:");
- __android_log_write(ANDROID_LOG_WARN, kGoogleBreakpad,
- android_build_info->gms_version_code());
AndroidLogWriteHorizontalRule();
if (!is_browser_process &&
@@ -1598,6 +1594,7 @@ void HandleCrashDump(const BreakpadInfo& info) {
static const char android_build_id[] = "android_build_id";
static const char android_build_fp[] = "android_build_fp";
static const char device[] = "device";
+ static const char gms_core_version[] = "gms_core_version";
static const char model[] = "model";
static const char brand[] = "brand";
static const char exception_info[] = "exception_info";
@@ -1616,6 +1613,9 @@ void HandleCrashDump(const BreakpadInfo& info) {
writer.AddBoundary();
writer.AddPairString(brand, android_build_info->brand());
writer.AddBoundary();
+ writer.AddPairString(gms_core_version,
+ android_build_info->gms_version_code());
+ writer.AddBoundary();
if (android_build_info->java_exception_info() != nullptr) {
writer.AddPairString(exception_info,
android_build_info->java_exception_info());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698