Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2089333003: compile.py: Simplify --build-tool logic. It's always ninja now. (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

compile.py: Simplify --build-tool logic. It's always ninja now. BUG=none Committed: https://chromium.googlesource.com/chromium/tools/build/+/0a2c62a48b28ce87da2409b08cdf2c6d50d75bc1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -23 lines) Patch
M scripts/slave/compile.py View 3 chunks +3 lines, -23 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Nico
I'll wait with landing this until the --project removal change has been in the tree ...
4 years, 6 months ago (2016-06-23 16:40:48 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-23 16:54:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2089333003/1
4 years, 5 months ago (2016-06-27 19:42:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/5755)
4 years, 5 months ago (2016-06-27 19:51:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2089333003/1
4 years, 5 months ago (2016-06-27 19:55:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/5757)
4 years, 5 months ago (2016-06-27 20:04:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2089333003/1
4 years, 5 months ago (2016-06-27 22:56:12 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 23:00:30 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/0a2c62a48b28ce87da24...

Powered by Google App Engine
This is Rietveld 408576698