Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: extensions/renderer/script_injection_manager.cc

Issue 2089333002: [Extensions] Add renderer-side logic to short circuit activity logging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Guard adding dom activity loggers Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/script_injection_manager.h ('k') | extensions/renderer/scripts_run_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/script_injection_manager.cc
diff --git a/extensions/renderer/script_injection_manager.cc b/extensions/renderer/script_injection_manager.cc
index eddd599f919a29e2587865f39418ba8a1d1ef860..f6743c12b0f5de6697bede30d7bc930820059229 100644
--- a/extensions/renderer/script_injection_manager.cc
+++ b/extensions/renderer/script_injection_manager.cc
@@ -407,7 +407,7 @@ void ScriptInjectionManager::InjectScripts(
// We are done running in the frame.
active_injection_frames_.erase(frame);
- scripts_run_info.LogRun();
+ scripts_run_info.LogRun(activity_logging_enabled_);
}
void ScriptInjectionManager::TryToInject(
@@ -452,7 +452,8 @@ void ScriptInjectionManager::HandleExecuteCode(
std::unique_ptr<ScriptInjector>(
new ProgrammaticScriptInjector(params, render_frame)),
render_frame, std::move(injection_host),
- static_cast<UserScript::RunLocation>(params.run_at)));
+ static_cast<UserScript::RunLocation>(params.run_at),
+ activity_logging_enabled_));
FrameStatusMap::const_iterator iter = frame_statuses_.find(render_frame);
UserScript::RunLocation run_location =
@@ -477,7 +478,7 @@ void ScriptInjectionManager::HandleExecuteDeclarativeScript(
TryToInject(std::move(injection), UserScript::BROWSER_DRIVEN,
&scripts_run_info);
- scripts_run_info.LogRun();
+ scripts_run_info.LogRun(activity_logging_enabled_);
}
}
@@ -505,7 +506,7 @@ void ScriptInjectionManager::HandlePermitScriptInjection(int64_t request_id) {
&scripts_run_info);
if (res == ScriptInjection::INJECTION_BLOCKED)
running_injections_.push_back(std::move(injection));
- scripts_run_info.LogRun();
+ scripts_run_info.LogRun(activity_logging_enabled_);
}
} // namespace extensions
« no previous file with comments | « extensions/renderer/script_injection_manager.h ('k') | extensions/renderer/scripts_run_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698