Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: extensions/renderer/api_activity_logger.h

Issue 2089333002: [Extensions] Add renderer-side logic to short circuit activity logging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Guard adding dom activity loggers Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/extension_messages.h ('k') | extensions/renderer/api_activity_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_activity_logger.h
diff --git a/extensions/renderer/api_activity_logger.h b/extensions/renderer/api_activity_logger.h
index 63a4699a88db13d4a9ca08986ace78534e5ad21a..08f614a8a62d905d1eb1d7386f88547761466b7e 100644
--- a/extensions/renderer/api_activity_logger.h
+++ b/extensions/renderer/api_activity_logger.h
@@ -13,13 +13,15 @@
#include "v8/include/v8.h"
namespace extensions {
+class Dispatcher;
// Used to log extension API calls and events that are implemented with custom
// bindings.The actions are sent via IPC to extensions::ActivityLog for
// recording and display.
class APIActivityLogger : public ObjectBackedNativeHandler {
public:
- explicit APIActivityLogger(ScriptContext* context);
+ APIActivityLogger(ScriptContext* context, Dispatcher* dispatcher);
+ ~APIActivityLogger() override;
private:
// Used to distinguish API calls & events from each other in LogInternal.
@@ -30,19 +32,21 @@ class APIActivityLogger : public ObjectBackedNativeHandler {
// arg1 - API call name as a string
// arg2 - arguments to the API call
// arg3 - any extra logging info as a string (optional)
- static void LogAPICall(const v8::FunctionCallbackInfo<v8::Value>& args);
+ void LogAPICall(const v8::FunctionCallbackInfo<v8::Value>& args);
// This is ultimately invoked in bindings.js with JavaScript arguments.
// arg0 - extension ID as a string
// arg1 - Event name as a string
// arg2 - Event arguments
// arg3 - any extra logging info as a string (optional)
- static void LogEvent(const v8::FunctionCallbackInfo<v8::Value>& args);
+ void LogEvent(const v8::FunctionCallbackInfo<v8::Value>& args);
// LogAPICall and LogEvent are really the same underneath except for
// how they are ultimately dispatched to the log.
- static void LogInternal(const CallType call_type,
- const v8::FunctionCallbackInfo<v8::Value>& args);
+ void LogInternal(const CallType call_type,
+ const v8::FunctionCallbackInfo<v8::Value>& args);
+
+ Dispatcher* dispatcher_;
DISALLOW_COPY_AND_ASSIGN(APIActivityLogger);
};
« no previous file with comments | « extensions/common/extension_messages.h ('k') | extensions/renderer/api_activity_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698