Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: extensions/renderer/api_activity_logger.cc

Issue 2089333002: [Extensions] Add renderer-side logic to short circuit activity logging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Guard adding dom activity loggers Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_activity_logger.h ('k') | extensions/renderer/dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_activity_logger.cc
diff --git a/extensions/renderer/api_activity_logger.cc b/extensions/renderer/api_activity_logger.cc
index ab4c67e4dc34b5e45f909ac0bf3f4611bda28232..08eb53e26493857fda7d04470d57f714f30dc05e 100644
--- a/extensions/renderer/api_activity_logger.cc
+++ b/extensions/renderer/api_activity_logger.cc
@@ -12,18 +12,24 @@
#include "extensions/common/extension_messages.h"
#include "extensions/renderer/activity_log_converter_strategy.h"
#include "extensions/renderer/api_activity_logger.h"
+#include "extensions/renderer/dispatcher.h"
#include "extensions/renderer/script_context.h"
using content::V8ValueConverter;
namespace extensions {
-APIActivityLogger::APIActivityLogger(ScriptContext* context)
- : ObjectBackedNativeHandler(context) {
- RouteFunction("LogEvent", base::Bind(&APIActivityLogger::LogEvent));
- RouteFunction("LogAPICall", base::Bind(&APIActivityLogger::LogAPICall));
+APIActivityLogger::APIActivityLogger(ScriptContext* context,
+ Dispatcher* dispatcher)
+ : ObjectBackedNativeHandler(context), dispatcher_(dispatcher) {
+ RouteFunction("LogEvent", base::Bind(&APIActivityLogger::LogEvent,
+ base::Unretained(this)));
+ RouteFunction("LogAPICall", base::Bind(&APIActivityLogger::LogAPICall,
+ base::Unretained(this)));
}
+APIActivityLogger::~APIActivityLogger() {}
+
// static
void APIActivityLogger::LogAPICall(
const v8::FunctionCallbackInfo<v8::Value>& args) {
@@ -45,6 +51,9 @@ void APIActivityLogger::LogInternal(
CHECK(args[1]->IsString());
CHECK(args[2]->IsArray());
+ if (!dispatcher_->activity_logging_enabled())
+ return;
+
std::string ext_id = *v8::String::Utf8Value(args[0]);
ExtensionHostMsg_APIActionOrEvent_Params params;
params.api_call = *v8::String::Utf8Value(args[1]);
« no previous file with comments | « extensions/renderer/api_activity_logger.h ('k') | extensions/renderer/dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698