Source/core/css/CSSSelector.h - Issue 208933006: Only :host and :ancestor should ever match the host in a ShadowRoot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSSelector.h

Issue 208933006: Only :host and :ancestor should ever match the host in a ShadowRoot (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add a test for :first-child too Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSSelector.h

diff --git a/Source/core/css/CSSSelector.h b/Source/core/css/CSSSelector.h

index 3cf279ce8e3c29ce6eb603b9b4760337d82cad94..34eba5772adc2e4822e8ad24c740000a4cb33119 100644

--- a/Source/core/css/CSSSelector.h

+++ b/Source/core/css/CSSSelector.h

@@ -386,7 +386,7 @@ inline bool CSSSelector::isCustomPseudoElement() const

inline bool CSSSelector::isHostPseudoClass() const

{

- return m_match == PseudoClass && m_pseudoType == PseudoHost;

+ return m_match == PseudoClass && (m_pseudoType == PseudoHost || m_pseudoType == PseudoAncestor);

}

inline bool CSSSelector::isSiblingSelector() const

« no previous file with comments | « Source/core/css/CSSParserValues.cpp ('k') | Source/core/css/SelectorChecker.cpp » ('j') | no next file with comments »