Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 208933003: Remove SiblingRuleHelper (Closed)

Created:
6 years, 9 months ago by esprehn
Modified:
6 years, 9 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, Inactive, rwlbuis
Visibility:
Public.

Description

Remove SiblingRuleHelper Since the bits are actually stored in NodeRareData anyway, we should just use those same bits for ShadowRoot and get rid of all this code duplication. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169787

Patch Set 1 #

Total comments: 1

Patch Set 2 : Tighten types to ContainerNode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -462 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 11 chunks +32 lines, -39 lines 0 comments Download
M Source/core/css/resolver/SharedStyleFinder.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/dom/ContainerNode.h View 1 4 chunks +58 lines, -1 line 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 1 chunk +47 lines, -0 lines 0 comments Download
M Source/core/dom/Element.h View 3 chunks +2 lines, -61 lines 0 comments Download
M Source/core/dom/Element.cpp View 6 chunks +8 lines, -10 lines 0 comments Download
M Source/core/dom/ElementRareData.h View 2 chunks +3 lines, -18 lines 0 comments Download
M Source/core/dom/Node.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/dom/NodeRareData.h View 3 chunks +11 lines, -5 lines 0 comments Download
M Source/core/dom/NodeRareData.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
D Source/core/dom/SiblingRuleHelper.h View 1 chunk +0 lines, -47 lines 0 comments Download
D Source/core/dom/SiblingRuleHelper.cpp View 1 chunk +0 lines, -143 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.h View 1 chunk +0 lines, -18 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 3 chunks +2 lines, -80 lines 0 comments Download
M Source/core/dom/shadow/ShadowRootRareData.h View 3 chunks +0 lines, -31 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
esprehn
6 years, 9 months ago (2014-03-21 21:51:16 UTC) #1
ojan
https://codereview.chromium.org/208933003/diff/1/Source/core/dom/Node.h File Source/core/dom/Node.h (right): https://codereview.chromium.org/208933003/diff/1/Source/core/dom/Node.h#newcode395 Source/core/dom/Node.h:395: bool childrenAffectedByFocus() const { return hasRestyleFlag(ChildrenAffectedByFocus); } What isn't ...
6 years, 9 months ago (2014-03-21 22:39:12 UTC) #2
esprehn
On 2014/03/21 22:39:12, ojan wrote: > https://codereview.chromium.org/208933003/diff/1/Source/core/dom/Node.h > File Source/core/dom/Node.h (right): > > https://codereview.chromium.org/208933003/diff/1/Source/core/dom/Node.h#newcode395 > ...
6 years, 9 months ago (2014-03-21 23:05:38 UTC) #3
ojan
lgtm
6 years, 9 months ago (2014-03-21 23:16:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/208933003/20001
6 years, 9 months ago (2014-03-21 23:16:43 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 23:20:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-21 23:20:01 UTC) #7
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-22 00:35:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/208933003/20001
6 years, 9 months ago (2014-03-22 00:36:00 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-22 00:39:29 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-22 00:39:30 UTC) #11
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-22 00:44:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/208933003/20001
6 years, 9 months ago (2014-03-22 00:44:53 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-22 01:36:13 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-22 01:36:13 UTC) #15
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-22 01:53:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/208933003/20001
6 years, 9 months ago (2014-03-22 01:53:17 UTC) #17
commit-bot: I haz the power
6 years, 9 months ago (2014-03-22 04:35:12 UTC) #18
Message was sent while issue was closed. 
Change committed as 169787

Powered by Google App Engine
This is Rietveld 408576698