Refactored FullscreenController

Refactored FullscreenController

Removed the toggle between Presentation Mode and Fullscreen.
Renamed UpdateFullscreenWithToolbar to UpdateUIForTabFullscreen.
Fixed the fullscreen toolbar logic in BWC so that the toolbar state is
correct when we exit tab fullscreen.

BUG=579259
Committed: https://crrev.com/33318204d192b80a9d41f6ca047266d6fc3dfa1f
Cr-Commit-Position: refs/heads/master@{#402677}

[spqchan, 2016-06-22 21:03:11]

Description was changed from

==========
Refactored FullscreenController logic

BUG=
==========

to

==========
Refactored FullscreenController

Fixed the logic for 

BUG=
==========

[spqchan, 2016-06-22 21:21:01]

Description was changed from

==========
Refactored FullscreenController

Fixed the logic for 

BUG=
==========

to

==========
Refactored FullscreenController

Removed the toggle between Presentation Mode and Fullscreen.
Renamed UpdateFullscreenWithToolbar to UpdateUIForTabFullscreen.

BUG=579259
==========

[spqchan, 2016-06-22 21:21:01]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org, thakis@chromium.org

[spqchan, 2016-06-22 21:26:39]

PTAL

+ rsesek for cocoa
+ thakis for everything else

[Nico, 2016-06-22 21:35:54]

general comment on bool parameters: I like enums more since

  do_something(false);

is harder to read than

  do_something(AGAINST_STRAWBERRIES);

But if you want to keep the bool params, please make clear what the parameter
means at the calling site like so:

  do_something(/*support_strawberries=*/false);

https://codereview.chromium.org/2089323002/diff/20001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/fullscreen_controller.cc (left):

https://codereview.chromium.org/2089323002/diff/20001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/fullscreen_controller.cc:351: #endif
why is this block no longer needed?

[spqchan, 2016-06-22 22:33:37]

PTAL

Made changes for thakis

https://codereview.chromium.org/2089323002/diff/20001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/fullscreen_controller.cc (left):

https://codereview.chromium.org/2089323002/diff/20001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/fullscreen_controller.cc:351: #endif
On 2016/06/22 21:35:54, Nico wrote:
> why is this block no longer needed?
This is only used if we're switching between Presentation Mode and Fullscreen.
Since Presentation Mode no longer exists, this is dead code.

[Nico, 2016-06-27 18:14:16]

lgtm, but i don't fully understand the changes in one of the files.

https://codereview.chromium.org/2089323002/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

https://codereview.chromium.org/2089323002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller.mm:1893: :
fullscreen_mac::OMNIBOX_TABS_HIDDEN];
i can't quite follow the changes in this file

[spqchan, 2016-06-27 18:17:04]

Description was changed from

==========
Refactored FullscreenController

Removed the toggle between Presentation Mode and Fullscreen.
Renamed UpdateFullscreenWithToolbar to UpdateUIForTabFullscreen.

BUG=579259
==========

to

==========
Refactored FullscreenController

Removed the toggle between Presentation Mode and Fullscreen.
Renamed UpdateFullscreenWithToolbar to UpdateUIForTabFullscreen.
Fixed the fullscreen toolbar logic in BWC so that the toolbar state is
correct when we exit tab fullscreen.

BUG=579259
==========

[spqchan, 2016-06-27 18:33:49]

Thanks! Ping for rsesek on the cocoa stuff

https://codereview.chromium.org/2089323002/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

https://codereview.chromium.org/2089323002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller.mm:1893: :
fullscreen_mac::OMNIBOX_TABS_HIDDEN];
On 2016/06/27 18:14:16, Nico wrote:
> i can't quite follow the changes in this file

The changes in this file are less of a refactor, and more of a fix.  I updated
the CL description to reflect this. The old code updateWithToolbar was
incorrectly setting the the fullscreen style to be always OMNIBOX_TABS_PRESENT
after exiting fullscreen.

[Robert Sesek, 2016-06-28 22:29:41]

lgtm

[spqchan, 2016-06-28 22:45:37]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-06-28 22:45:45]

thanks!

[commit-bot: I haz the power, 2016-06-28 22:47:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 23:20:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 23:20:03]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[spqchan, 2016-06-29 01:41:29]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-06-29 01:41:30]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2089323002/#ps60001
(title: "Fixed test")

[commit-bot: I haz the power, 2016-06-29 01:43:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 02:30:14]

Description was changed from

==========
Refactored FullscreenController

Removed the toggle between Presentation Mode and Fullscreen.
Renamed UpdateFullscreenWithToolbar to UpdateUIForTabFullscreen.
Fixed the fullscreen toolbar logic in BWC so that the toolbar state is
correct when we exit tab fullscreen.

BUG=579259
==========

to

==========
Refactored FullscreenController

Removed the toggle between Presentation Mode and Fullscreen.
Renamed UpdateFullscreenWithToolbar to UpdateUIForTabFullscreen.
Fixed the fullscreen toolbar logic in BWC so that the toolbar state is
correct when we exit tab fullscreen.

BUG=579259
==========

[commit-bot: I haz the power, 2016-06-29 02:30:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-29 02:32:26]

Description was changed from

==========
Refactored FullscreenController

Removed the toggle between Presentation Mode and Fullscreen.
Renamed UpdateFullscreenWithToolbar to UpdateUIForTabFullscreen.
Fixed the fullscreen toolbar logic in BWC so that the toolbar state is
correct when we exit tab fullscreen.

BUG=579259
==========

to

==========
Refactored FullscreenController

Removed the toggle between Presentation Mode and Fullscreen.
Renamed UpdateFullscreenWithToolbar to UpdateUIForTabFullscreen.
Fixed the fullscreen toolbar logic in BWC so that the toolbar state is
correct when we exit tab fullscreen.

BUG=579259

Committed: https://crrev.com/33318204d192b80a9d41f6ca047266d6fc3dfa1f
Cr-Commit-Position: refs/heads/master@{#402677}
==========

[commit-bot: I haz the power, 2016-06-29 02:32:27]

Patchset 4 (id:??) landed as
https://crrev.com/33318204d192b80a9d41f6ca047266d6fc3dfa1f
Cr-Commit-Position: refs/heads/master@{#402677}