Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 2089313005: Revert of MD Settings: make custom UIs look "actionable" (Closed)

Created:
4 years, 6 months ago by blundell
Modified:
4 years, 6 months ago
Reviewers:
Dan Beam, dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, tommycli
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MD Settings: make custom UIs look "actionable" (patchset #3 id:40001 of https://codereview.chromium.org/2094813002/ ) Reason for revert: This CL causes SettingLanguagesBrowserTest.LanguagesPage to fail on ChromiumOS and Win7 (confirmed by building ChromeOS locally in Release, observing the failure, reverting the CL, and seeing that the failure goes away). Example failure: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/21718/steps/browser_tests%20on%20Ubuntu-12.04/logs/SettingsLanguagesPageBrowserTest.LanguagesPage. Relevant snippet from test output: [11504:11504:0624/023830:INFO:CONSOLE(1196)] "Running TestCase SettingsLanguagesPageBrowserTest.MAYBE_LanguagesPage", source: test_api.js (1196) [11504:11504:0624/023830:ERROR:CONSOLE(44)] "Mocha test failed: languages page manage languages AssertionError: expected false to be true at Function.assert.isTrue (chai.js:2423:31) at assertTrue (test_api.js:851:17) at Context.<anonymous> (languages_page_browsertest.js:81:7) ", source: mocha_adapter.js (44) Original issue's description: > MD Settings: make custom UIs look "actionable" > > Currently, that just entails a cursor: pointer; but may involve e.g. a > :hover effect in the future. > > This introduces the shared variable: > > --settings-actionable: { > cursor: pointer; > }; > > which can be used from places that don't want all the settings shared > style (which generally applies to the sections in the middle). > > .my-custom-thing { > @apply(--settings-actionable); > } > > For stuff inside of <settings-main> (or code otherwise using > settings-shared), it's probably easier to just use the new: > > [actionable] { > @apply(--settings-actionable); > } > > and just annotate your element with that attribute, i.e. > > <div id="frobber" on-tap="onFrobberTap_" actionable> > > FYI: This CL is semi-automatedly generated via: > > vim -p `git grep -l on-tap -- chrome/browser/resources/settings` > > and lots of hacking. > > R=dpapad@chromium.org > BUG=611826 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/a298aa9c3276b78073a61613787909a0b2427302 > Cr-Commit-Position: refs/heads/master@{#401763} TBR=dpapad@chromium.org,dbeam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=611826 Committed: https://crrev.com/65fef050ca882d64532c57ce7d7c27ad98f2016b Cr-Commit-Position: refs/heads/master@{#401843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -103 lines) Patch
M chrome/browser/resources/settings/about_page/about_page.html View 3 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/default_browser_page/default_browser_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/device_page.html View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/device_page/keyboard.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy_exclusions.html View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary_item.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/languages_page/languages_page.html View 3 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/languages_page.js View 1 chunk +5 lines, -14 lines 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_urls_page.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.html View 4 chunks +13 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/people_page/sync_page.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/reset_page/reset_page.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_main/settings_main.html View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/settings_root_css.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_list.html View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/site_settings_page/site_settings_page.html View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
blundell
Created Revert of MD Settings: make custom UIs look "actionable"
4 years, 6 months ago (2016-06-24 09:57:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089313005/1
4 years, 6 months ago (2016-06-24 09:57:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 09:58:33 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 10:00:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65fef050ca882d64532c57ce7d7c27ad98f2016b
Cr-Commit-Position: refs/heads/master@{#401843}

Powered by Google App Engine
This is Rietveld 408576698