Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 208923002: Remove the url parameter from blink::Platform::userAgent since it's not used anymore. (Closed)

Created:
6 years, 9 months ago by jam
Modified:
6 years, 9 months ago
Reviewers:
jamesr, dglazkov, nasko
CC:
blink-reviews, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove the url parameter from blink::Platform::userAgent since it's not used anymore. BUG=304341 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/web/FrameLoaderClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/Platform.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jam
6 years, 9 months ago (2014-03-21 20:28:50 UTC) #1
nasko
lgtm
6 years, 9 months ago (2014-03-21 20:58:22 UTC) #2
jam
since jamesr is gone, switching to dglazkov
6 years, 9 months ago (2014-03-21 22:49:10 UTC) #3
jamesr
lgtm
6 years, 9 months ago (2014-03-22 20:32:14 UTC) #4
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-24 16:29:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/208923002/1
6 years, 9 months ago (2014-03-24 16:29:39 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 16:30:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-24 16:30:45 UTC) #8
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-24 16:36:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/208923002/1
6 years, 9 months ago (2014-03-24 16:36:23 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 17:09:00 UTC) #11
Message was sent while issue was closed. 
Change committed as 169863

Powered by Google App Engine
This is Rietveld 408576698