Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: scripts/master/chromium_step.py

Issue 2089223003: annotations: change meaning of STEP_TEXT (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: remove step name from step text Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/chromium_step.py
diff --git a/scripts/master/chromium_step.py b/scripts/master/chromium_step.py
index 7294981f3a6c37200f964512a4e3ffc9913c96ec..908fffa01e114dea4d79c0f758ca9c90fd64ef42 100644
--- a/scripts/master/chromium_step.py
+++ b/scripts/master/chromium_step.py
@@ -47,7 +47,7 @@ def updateText(section):
else:
result = []
- section['step'].setText([section['name']] + section['step_text'])
+ section['step'].setText(['<br>'.join(section['step_text'])])
section['step'].setText2(result + section['step_summary_text'])
@@ -542,11 +542,11 @@ class AnnotationObserver(buildstep.LogLineObserver):
@@@STEP_SUMMARY_CLEAR@@@
Reset the text summary of the current step.
- @@@STEP_TEXT@<msg>@@@
- Append <msg> to the current step text.
+ @@@STEP_TEXT@<msg line>@@@
+ Append <msg line> to the current step text.
- @@@SEED_STEP_TEXT@step@<msg>@@@
- Append <msg> to the specified seeded step.
+ @@@SEED_STEP_TEXT@step@<msg line>@@@
+ Append <msg line> to the specified seeded step.
@@@STEP_SUMMARY_TEXT@<msg>@@@
Append <msg> to the step summary (appears on top of the waterfall).
@@ -945,7 +945,7 @@ class AnnotationObserver(buildstep.LogLineObserver):
"""Adds a new section to annotator sections, does not change cursor."""
if not step:
step = self.command.step_status.getBuild().addStepWithName(step_name)
- step.setText([step_name])
+ step.setText([])
self.sections.append({
'name': step_name,
'step': step,
@@ -956,6 +956,7 @@ class AnnotationObserver(buildstep.LogLineObserver):
'status': builder.SUCCESS,
'links': [],
'step_summary_text': [],
+ # step_text is a list of lines that will printed after step name.
'step_text': [],
'started': None,
'async_ops': [],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698