annotations: change meaning of STEP_TEXT

scripts/master/chromium_step.py

Index: scripts/master/chromium_step.py
diff --git a/scripts/master/chromium_step.py b/scripts/master/chromium_step.py
index 7294981f3a6c37200f964512a4e3ffc9913c96ec..a8e643c4174c622b1507da81e61e3044098a6843 100644
--- a/scripts/master/chromium_step.py
+++ b/scripts/master/chromium_step.py
@@ -47,7 +47,8 @@ def updateText(section):
   else:
     result = []
 
-  section['step'].setText([section['name']] + section['step_text'])
+  step_text = ['<br>%s' % line for line in section['step_text']]

[Ryan Tseng, 2016/06/22 22:44:24]

I think we the first line of step_text to be on the same line, right?

[nodir, 2016/06/22 22:47:21]

Dunno. Note that it will get mixed with step name. It was always confusing to
me, why does buildbot display "<step name again> <step text>" on the same line. 

we could remove step name too. wdyt?

[Ryan Tseng, 2016/06/22 22:50:08]

yeah removing step name sounds good to me, i'm savvy.

[nodir, 2016/06/22 22:56:19]

Done. http://imgur.com/BWUWRbH

+  section['step'].setText([section['name']] + step_text)
   section['step'].setText2(result + section['step_summary_text'])
 
 
@@ -542,11 +543,11 @@ class AnnotationObserver(buildstep.LogLineObserver):
   @@@STEP_SUMMARY_CLEAR@@@
   Reset the text summary of the current step.
 
-  @@@STEP_TEXT@<msg>@@@
-  Append <msg> to the current step text.
+  @@@STEP_TEXT@<msg line>@@@
+  Append <msg line> to the current step text.
 
-  @@@SEED_STEP_TEXT@step@<msg>@@@
-  Append <msg> to the specified seeded step.
+  @@@SEED_STEP_TEXT@step@<msg line>@@@
+  Append <msg line> to the specified seeded step.
 
   @@@STEP_SUMMARY_TEXT@<msg>@@@
   Append <msg> to the step summary (appears on top of the waterfall).
@@ -945,7 +946,7 @@ class AnnotationObserver(buildstep.LogLineObserver):
     """Adds a new section to annotator sections, does not change cursor."""
     if not step:
       step = self.command.step_status.getBuild().addStepWithName(step_name)
-      step.setText([step_name])
+      step.setText([])
     self.sections.append({
         'name': step_name,
         'step': step,
@@ -956,6 +957,7 @@ class AnnotationObserver(buildstep.LogLineObserver):
         'status': builder.SUCCESS,
         'links': [],
         'step_summary_text': [],
+        # step_text is a list of lines that will printed after step name.
         'step_text': [],
         'started': None,
         'async_ops': [],