Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: third_party/WebKit/Source/core/dom/ContainerNode.h

Issue 2089063005: Schedule sibling invalidation sets for sibling insert/remove. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed minDirectAdjacent optimization. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ContainerNode.h
diff --git a/third_party/WebKit/Source/core/dom/ContainerNode.h b/third_party/WebKit/Source/core/dom/ContainerNode.h
index fa766655a7b1bd4de61635d00b020dda570d7442..69fa207e326fc98572f37961b08a5f03a36f4ea8 100644
--- a/third_party/WebKit/Source/core/dom/ContainerNode.h
+++ b/third_party/WebKit/Source/core/dom/ContainerNode.h
@@ -158,7 +158,7 @@ public:
// FIXME: These methods should all be renamed to something better than "check",
// since it's not clear that they alter the style bits of siblings and children.
enum SiblingCheckType { FinishedParsingChildren, SiblingElementInserted, SiblingElementRemoved };
- void checkForSiblingStyleChanges(SiblingCheckType, Node* nodeBeforeChange, Node* nodeAfterChange);
+ void checkForSiblingStyleChanges(SiblingCheckType, Node* changedNode, Node* nodeBeforeChange, Node* nodeAfterChange);
void recalcChildStyle(StyleRecalcChange);
bool childrenSupportStyleSharing() const { return !hasRestyleFlags(); }
@@ -175,6 +175,7 @@ public:
{
ChildrenChange change = {
node.isElementNode() ? ElementInserted : NonElementInserted,
+ &node,
node.previousSibling(),
node.nextSibling(),
byParser
@@ -186,6 +187,7 @@ public:
{
ChildrenChange change = {
node.isElementNode() ? ElementRemoved : NonElementRemoved,
+ &node,
previousSibling,
nextSibling,
byParser
@@ -198,6 +200,7 @@ public:
bool isChildElementChange() const { return type == ElementInserted || type == ElementRemoved; }
ChildrenChangeType type;
+ Member<Node> siblingChanged;
Member<Node> siblingBeforeChange;
Member<Node> siblingAfterChange;
ChildrenChangeSource byParser;
« no previous file with comments | « third_party/WebKit/Source/core/dom/CharacterData.cpp ('k') | third_party/WebKit/Source/core/dom/ContainerNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698