Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/IceInstMIPS32.def

Issue 2089043003: Subzero, MIPS32: Fix FP register table (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceInstMIPS32.def
diff --git a/src/IceInstMIPS32.def b/src/IceInstMIPS32.def
index 0115bc427c335bd4574166dafc5326a364ad07f6..005c340f31e05fbe56ba23b77a69845da5e90ab3 100644
--- a/src/IceInstMIPS32.def
+++ b/src/IceInstMIPS32.def
@@ -111,13 +111,13 @@
#define REGMIPS32_FPR_TABLE \
/* val, encode, name, scratch, preserved, stackptr, frameptr, \
isInt, isI64Pair, isFP32, isFP64, isVec128, alias_init */ \
- X(Reg_F0, 0, "f0", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F0, 0, "f0", 0,0,0,0, 0,0,1,0,0, \
Jim Stichnoth 2016/06/22 15:48:49 I don't think this is right. This cluster of 4 va
obucinac 2016/06/22 16:28:33 f0-f3 are used for function return values. f12-f1
Jim Stichnoth 2016/06/25 15:18:46 OK, looks good. FYI, if for some reason you want
ALIASES2(Reg_F0, Reg_F0F1)) \
- X(Reg_F1, 1, "f1", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F1, 1, "f1", 0,0,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F1, Reg_F0F1)) \
- X(Reg_F2, 2, "f2", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F2, 2, "f2", 0,0,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F2, Reg_F2F3)) \
- X(Reg_F3, 3, "f3", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F3, 3, "f3", 0,0,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F3, Reg_F2F3)) \
X(Reg_F4, 4, "f4", 1,0,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F4, Reg_F4F5)) \
@@ -135,13 +135,13 @@
ALIASES2(Reg_F10, Reg_F10F11)) \
X(Reg_F11, 11, "f11", 1,0,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F11, Reg_F10F11)) \
- X(Reg_F12, 12, "f12", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F12, 12, "f12", 0,0,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F12, Reg_F12F13)) \
- X(Reg_F13, 13, "f13", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F13, 13, "f13", 0,0,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F13, Reg_F12F13)) \
- X(Reg_F14, 14, "f14", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F14, 14, "f14", 0,0,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F14, Reg_F14F15)) \
- X(Reg_F15, 15, "f15", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F15, 15, "f15", 0,0,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F15, Reg_F14F15)) \
X(Reg_F16, 16, "f16", 1,0,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F16, Reg_F16F17)) \
@@ -151,30 +151,30 @@
ALIASES2(Reg_F18, Reg_F18F19)) \
X(Reg_F19, 19, "f19", 1,0,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F19, Reg_F18F19)) \
- X(Reg_F20, 20, "f20", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F20, 20, "f20", 0,1,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F20, Reg_F20F21)) \
- X(Reg_F21, 21, "f21", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F21, 21, "f21", 0,1,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F21, Reg_F20F21)) \
- X(Reg_F22, 22, "f22", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F22, 22, "f22", 0,1,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F22, Reg_F22F23)) \
- X(Reg_F23, 23, "f23", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F23, 23, "f23", 0,1,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F23, Reg_F22F23)) \
- X(Reg_F24, 24, "f24", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F24, 24, "f24", 0,1,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F24, Reg_F24F25)) \
- X(Reg_F25, 25, "f25", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F25, 25, "f25", 0,1,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F25, Reg_F24F25)) \
- X(Reg_F26, 26, "f26", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F26, 26, "f26", 0,1,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F26, Reg_F26F27)) \
- X(Reg_F27, 27, "f27", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F27, 27, "f27", 0,1,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F27, Reg_F26F27)) \
- X(Reg_F28, 28, "f28", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F28, 28, "f28", 0,1,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F28, Reg_F28F29)) \
- X(Reg_F29, 29, "f29", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F29, 29, "f29", 0,1,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F29, Reg_F28F29)) \
- X(Reg_F30, 30, "f30", 1,0,0,0, 0,0,1,0,0, \
+ X(Reg_F30, 30, "f30", 0,1,0,0, 0,0,1,0,0, \
ALIASES2(Reg_F30, Reg_F30F31)) \
- X(Reg_F31, 31, "f31", 1,0,0,0, 0,0,1,0,0, \
- ALIASES2(Reg_F31, Reg_F30F31)) \
+ X(Reg_F31, 31, "f31", 0,1,0,0, 0,0,1,0,0, \
+ ALIASES2(Reg_F31, Reg_F30F31))
//#define X(val, encode, name, scratch, preserved, stackptr, frameptr,
// isInt, isI64Pair, isFP32, isFP64, isVec128, alias_init)
@@ -218,37 +218,37 @@
#define REGMIPS32_F64PAIR_TABLE \
/* val, encode, name, scratch, preserved, stackptr, frameptr, \
isInt, isI64Pair, isFP32, isFP64, isVec128, alias_init */ \
- X(Reg_F0F1, 0, "f0, f1", 1,0,0,0, 0,0,0,1,0, \
+ X(Reg_F0F1, 0, "f0", 0,0,0,0, 0,0,0,1,0, \
ALIASES3(Reg_F0, Reg_F1, Reg_F0F1)) \
- X(Reg_F2F3, 2, "f2, f3", 1,0,0,0, 0,0,0,1,0, \
+ X(Reg_F2F3, 2, "f2", 0,0,0,0, 0,0,0,1,0, \
ALIASES3(Reg_F2, Reg_F3, Reg_F2F3)) \
- X(Reg_F4F5, 4, "f4, f5", 1,0,0,0, 0,0,0,1,0, \
+ X(Reg_F4F5, 4, "f4", 1,0,0,0, 0,0,0,1,0, \
ALIASES3(Reg_F4, Reg_F5, Reg_F4F5)) \
- X(Reg_F6F7, 6, "f6, f7", 1,0,0,0, 0,0,0,1,0, \
+ X(Reg_F6F7, 6, "f6", 1,0,0,0, 0,0,0,1,0, \
ALIASES3(Reg_F6, Reg_F7, Reg_F6F7)) \
- X(Reg_F8F9, 8, "f8, f9", 1,0,0,0, 0,0,0,1,0, \
+ X(Reg_F8F9, 8, "f8", 1,0,0,0, 0,0,0,1,0, \
ALIASES3(Reg_F8, Reg_F9, Reg_F8F9)) \
- X(Reg_F10F11, 10, "f10, f11", 1,0,0,0, 0,0,0,1,0, \
+ X(Reg_F10F11, 10, "f10", 1,0,0,0, 0,0,0,1,0, \
ALIASES3(Reg_F10, Reg_F11, Reg_F10F11)) \
- X(Reg_F12F13, 12, "f12, f13", 1,0,0,0, 0,0,0,1,0, \
+ X(Reg_F12F13, 12, "f12", 0,0,0,0, 0,0,0,1,0, \
ALIASES3(Reg_F12, Reg_F13, Reg_F12F13)) \
- X(Reg_F14F15, 14, "f14, f15", 1,0,0,0, 0,0,0,1,0, \
+ X(Reg_F14F15, 14, "f14", 0,0,0,0, 0,0,0,1,0, \
ALIASES3(Reg_F14, Reg_F15, Reg_F14F15)) \
- X(Reg_F16F17, 16, "f16, f17", 1,0,0,0, 0,0,0,1,0, \
+ X(Reg_F16F17, 16, "f16", 1,0,0,0, 0,0,0,1,0, \
ALIASES3(Reg_F16, Reg_F17, Reg_F16F17)) \
- X(Reg_F18F19, 18, "f18, f19", 1,0,0,0, 0,0,0,1,0, \
+ X(Reg_F18F19, 18, "f18", 1,0,0,0, 0,0,0,1,0, \
ALIASES3(Reg_F18, Reg_F19, Reg_F18F19)) \
- X(Reg_F20F21, 20, "f20, f21", 1,0,0,0, 0,0,0,1,0, \
+ X(Reg_F20F21, 20, "f20", 0,1,0,0, 0,0,0,1,0, \
ALIASES3(Reg_F20, Reg_F21, Reg_F20F21)) \
- X(Reg_F22F23, 22, "f22, f23", 1,0,0,0, 0,0,0,1,0, \
+ X(Reg_F22F23, 22, "f22", 0,1,0,0, 0,0,0,1,0, \
ALIASES3(Reg_F22, Reg_F23, Reg_F22F23)) \
- X(Reg_F24F25, 24, "f24, f25", 1,0,0,0, 0,0,0,1,0, \
+ X(Reg_F24F25, 24, "f24", 0,1,0,0, 0,0,0,1,0, \
ALIASES3(Reg_F24, Reg_F25, Reg_F24F25)) \
- X(Reg_F26F27, 26, "f26, f27", 1,0,0,0, 0,0,0,1,0, \
+ X(Reg_F26F27, 26, "f26", 0,1,0,0, 0,0,0,1,0, \
ALIASES3(Reg_F26, Reg_F27, Reg_F26F27)) \
- X(Reg_F28F29, 28, "f28, f29", 1,0,0,0, 0,0,0,1,0, \
+ X(Reg_F28F29, 28, "f28", 0,1,0,0, 0,0,0,1,0, \
ALIASES3(Reg_F28, Reg_F29, Reg_F28F29)) \
- X(Reg_F30F31, 30, "f30, f31", 1,0,0,0, 0,0,0,1,0, \
+ X(Reg_F30F31, 30, "f30", 0,1,0,0, 0,0,0,1,0, \
ALIASES3(Reg_F30, Reg_F31, Reg_F30F31))
// We also provide a combined table, so that there is a namespace where
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698