Add Physical Web experiment and command line flags

Add Physical Web experiment and command line flags

BUG=600616
Committed: https://crrev.com/c9f1df527205967aacd1a9ee51db1c8706dd61b5
Cr-Commit-Position: refs/heads/master@{#402754}

[mattreynolds, 2016-06-22 19:46:49]

mattreynolds@chromium.org changed reviewers:
+ olivierrobin@google.com

[mattreynolds, 2016-06-22 19:46:50]

Hi Olivier, PTAL

[Olivier, 2016-06-23 08:37:36]

olivierrobin@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[Olivier, 2016-06-23 08:37:36]

Do you intend to add a flag an iOS experimental flag (in a setting toggle in
Experimental.plist?

[mattreynolds, 2016-06-23 18:04:13]

On 2016/06/23 08:37:36, Olivier Robin wrote:
> Do you intend to add a flag an iOS experimental flag (in a setting toggle in
> Experimental.plist?

Yes, I created a CL for that change as well but it looks like I didn't send an
email for it.

https://chromereviews.googleplex.com/451487013/

[Olivier, 2016-06-24 07:52:34]

https://codereview.chromium.org/2088993005/diff/1/ios/chrome/browser/experime...
File ios/chrome/browser/experimental_flags.mm (right):

https://codereview.chromium.org/2088993005/diff/1/ios/chrome/browser/experime...
ios/chrome/browser/experimental_flags.mm:125: base::CommandLine* command_line =
base::CommandLine::ForCurrentProcess();
I think you should check for the NSUserDefault to check for the experimental
flags in settings.

[mattreynolds, 2016-06-24 17:47:21]

https://codereview.chromium.org/2088993005/diff/1/ios/chrome/browser/experime...
File ios/chrome/browser/experimental_flags.mm (right):

https://codereview.chromium.org/2088993005/diff/1/ios/chrome/browser/experime...
ios/chrome/browser/experimental_flags.mm:125: base::CommandLine* command_line =
base::CommandLine::ForCurrentProcess();
On 2016/06/24 07:52:33, Olivier Robin wrote:
> I think you should check for the NSUserDefault to check for the experimental
> flags in settings.

I think this is unnecessary because in about_flags.mm we append command line
switches for the default values.  I tried to follow the same pattern used by the
AllBookmarks switch above.

[mattreynolds, 2016-06-28 18:02:00]

mattreynolds@chromium.org changed reviewers:
+ rohitrao@chromium.org

[mattreynolds, 2016-06-28 18:02:01]

Hi Rohit, PTAL

[rohitrao (ping after 24h), 2016-06-28 18:18:40]

lgtm

[mattreynolds, 2016-06-28 19:31:37]

Olivier, do you have any more comments?

[Olivier, 2016-06-29 07:31:02]

The CQ bit was checked by olivierrobin@chromium.org

[Olivier, 2016-06-29 07:31:03]

lgtm

[commit-bot: I haz the power, 2016-06-29 07:31:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 08:30:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-29 08:31:44]

Description was changed from

==========
Add Physical Web experiment and command line flags

BUG=600616
==========

to

==========
Add Physical Web experiment and command line flags

BUG=600616

Committed: https://crrev.com/c9f1df527205967aacd1a9ee51db1c8706dd61b5
Cr-Commit-Position: refs/heads/master@{#402754}
==========

[commit-bot: I haz the power, 2016-06-29 08:31:45]

Patchset 1 (id:??) landed as
https://crrev.com/c9f1df527205967aacd1a9ee51db1c8706dd61b5
Cr-Commit-Position: refs/heads/master@{#402754}