Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2088983002:
Stop running tests on Mac GN builders and remove from the CQ. (Closed)
|
Created:
4 years, 6 months ago by Dirk Pranke Modified:
4 years, 6 months ago Reviewers:
Robert Sesek, jam CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionStop running tests on Mac GN builders and remove from the CQ.
Now that we've flipped the main Mac builders in the CQ to GN,
the GN builders are redundant and can be shut down.
R=jam@chromium.org, rsesek@chromium.org
BUG=618468
Committed: https://crrev.com/884703f4bf5590d99218a3bae5b01247e16746fb
Cr-Commit-Position: refs/heads/master@{#401361}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 22 (10 generated)
Description was changed from ========== Stop running tests on Mac GN builders and remove from the CQ. Now that we've flipped the main Mac builders in the CQ to GN, the GN builders are redundant and can be shut down. R=jam@chromium.or, rsesek@chromium.org BUG=618468 ========== to ========== Stop running tests on Mac GN builders and remove from the CQ. Now that we've flipped the main Mac builders in the CQ to GN, the GN builders are redundant and can be shut down. R=jam@chromium.org, rsesek@chromium.org BUG=618468 ==========
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088983002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088983002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088983002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2088983002/diff/1/testing/buildbot/chromium.m... File testing/buildbot/chromium.mac.json (right): https://codereview.chromium.org/2088983002/diff/1/testing/buildbot/chromium.m... testing/buildbot/chromium.mac.json:2: "Mac GN": { Why keep these around at all?
On 2016/06/22 16:56:45, Robert Sesek wrote: > https://codereview.chromium.org/2088983002/diff/1/testing/buildbot/chromium.m... > File testing/buildbot/chromium.mac.json (right): > > https://codereview.chromium.org/2088983002/diff/1/testing/buildbot/chromium.m... > testing/buildbot/chromium.mac.json:2: "Mac GN": { > Why keep these around at all? I need to keep the entries around until I can shut the builders down, which I will do soon. Then I'll remove the entries.
LGTM
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088983002/1
Message was sent while issue was closed.
Description was changed from ========== Stop running tests on Mac GN builders and remove from the CQ. Now that we've flipped the main Mac builders in the CQ to GN, the GN builders are redundant and can be shut down. R=jam@chromium.org, rsesek@chromium.org BUG=618468 ========== to ========== Stop running tests on Mac GN builders and remove from the CQ. Now that we've flipped the main Mac builders in the CQ to GN, the GN builders are redundant and can be shut down. R=jam@chromium.org, rsesek@chromium.org BUG=618468 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Stop running tests on Mac GN builders and remove from the CQ. Now that we've flipped the main Mac builders in the CQ to GN, the GN builders are redundant and can be shut down. R=jam@chromium.org, rsesek@chromium.org BUG=618468 ========== to ========== Stop running tests on Mac GN builders and remove from the CQ. Now that we've flipped the main Mac builders in the CQ to GN, the GN builders are redundant and can be shut down. R=jam@chromium.org, rsesek@chromium.org BUG=618468 Committed: https://crrev.com/884703f4bf5590d99218a3bae5b01247e16746fb Cr-Commit-Position: refs/heads/master@{#401361} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/884703f4bf5590d99218a3bae5b01247e16746fb Cr-Commit-Position: refs/heads/master@{#401361} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
