Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2088973002: Move v8 snapshot renaming code to v8/BUILD.gn (Closed)

Created:
4 years, 6 months ago by michaelbai
Modified:
4 years, 6 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move v8 snapshot renaming code to v8/BUILD.gn BUG=620855 Committed: https://crrev.com/5dc223a1b405951f7deec0fc8de076a0b4ec2d6c Cr-Commit-Position: refs/heads/master@{#401739}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M build_overrides/v8.gni View 1 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
michaelbai
4 years, 6 months ago (2016-06-21 22:16:33 UTC) #3
agrieve
On 2016/06/21 22:16:33, michaelbai wrote: lgtm
4 years, 6 months ago (2016-06-21 23:55:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088973002/1
4 years, 6 months ago (2016-06-23 19:56:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/25736) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-23 19:59:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088973002/20001
4 years, 6 months ago (2016-06-23 20:50:49 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-23 22:03:41 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 22:04:54 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5dc223a1b405951f7deec0fc8de076a0b4ec2d6c
Cr-Commit-Position: refs/heads/master@{#401739}

Powered by Google App Engine
This is Rietveld 408576698