Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: remoting/codec/video_decoder.h

Issue 2088953004: Fix VideoDecoderVpx to use pixel format the consumer wants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/software_video_renderer.cc ('k') | remoting/codec/video_decoder_verbatim.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/codec/video_decoder.h
diff --git a/remoting/codec/video_decoder.h b/remoting/codec/video_decoder.h
index 3ed5f5a6ae9652070a9b11b34776a0a195261b45..4bf4d573c9242dac2fb1f31c12bedd148da18d07 100644
--- a/remoting/codec/video_decoder.h
+++ b/remoting/codec/video_decoder.h
@@ -5,7 +5,6 @@
#ifndef REMOTING_CODEC_VIDEO_DECODER_H_
#define REMOTING_CODEC_VIDEO_DECODER_H_
-
namespace webrtc {
class DesktopFrame;
} // namespace webrtc
@@ -17,9 +16,14 @@ class VideoPacket;
// Interface for a decoder that decodes video packets.
class VideoDecoder {
public:
+ // List of supported pixel formats needed by various platforms.
+ enum class PixelFormat { BGRA, RGBA };
Lambros 2016/06/24 01:13:58 Seems a bit weird having this enumeration in two p
Sergey Ulanov 2016/06/24 02:01:09 I agree. The proper place for this enum would be w
+
VideoDecoder() {}
virtual ~VideoDecoder() {}
+ virtual void SetPixelFormat(PixelFormat pixel_format) = 0;
+
// Decodes a video frame. Returns false in case of a failure. The caller must
// pre-allocate a |frame| with the size specified in the |packet|.
virtual bool DecodePacket(const VideoPacket& packet,
« no previous file with comments | « remoting/client/software_video_renderer.cc ('k') | remoting/codec/video_decoder_verbatim.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698