Fix VideoDecoderVpx to use pixel format the consumer wants.

Fix VideoDecoderVpx to use pixel format the consumer wants.

Previously SoftwareVideoRenderer had to covert RGB to BGR using
RgbToBgrVideoDecoderFilter.

Committed: https://crrev.com/4ba8b7320c1e04f19af4809988a60d28fcdc09db
Cr-Commit-Position: refs/heads/master@{#401824}

[Sergey Ulanov, 2016-06-22 20:56:15]

sergeyu@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[Sergey Ulanov, 2016-06-24 00:51:46]

Lambros: ping

[Lambros, 2016-06-24 01:13:58]

lgtm

https://codereview.chromium.org/2088953004/diff/1/remoting/codec/video_decoder.h
File remoting/codec/video_decoder.h (right):

https://codereview.chromium.org/2088953004/diff/1/remoting/codec/video_decode...
remoting/codec/video_decoder.h:20: enum class PixelFormat { BGRA, RGBA };
Seems a bit weird having this enumeration in two places?

[Sergey Ulanov, 2016-06-24 02:01:10]

https://codereview.chromium.org/2088953004/diff/1/remoting/codec/video_decoder.h
File remoting/codec/video_decoder.h (right):

https://codereview.chromium.org/2088953004/diff/1/remoting/codec/video_decode...
remoting/codec/video_decoder.h:20: enum class PixelFormat { BGRA, RGBA };
On 2016/06/24 01:13:58, Lambros wrote:
> Seems a bit weird having this enumeration in two places?

I agree. The proper place for this enum would be webrtc::DesktopFrame, but I
don't want to add it there because I think we won't be using DesktopFrame on the
client long-term.

[Sergey Ulanov, 2016-06-24 02:03:06]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-06-24 02:03:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2088953004/1

[commit-bot: I haz the power, 2016-06-24 02:11:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 02:11:37]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2016-06-24 05:05:35]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-06-24 05:05:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2088953004/1

[commit-bot: I haz the power, 2016-06-24 05:52:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-24 05:54:19]

Description was changed from

==========
Fix VideoDecoderVpx to use pixel format the consumer wants.

Previously SoftwareVideoRenderer had to covert RGB to BGR using
RgbToBgrVideoDecoderFilter.
==========

to

==========
Fix VideoDecoderVpx to use pixel format the consumer wants.

Previously SoftwareVideoRenderer had to covert RGB to BGR using
RgbToBgrVideoDecoderFilter.

Committed: https://crrev.com/4ba8b7320c1e04f19af4809988a60d28fcdc09db
Cr-Commit-Position: refs/heads/master@{#401824}
==========

[commit-bot: I haz the power, 2016-06-24 05:54:20]

Patchset 1 (id:??) landed as
https://crrev.com/4ba8b7320c1e04f19af4809988a60d28fcdc09db
Cr-Commit-Position: refs/heads/master@{#401824}