Issue 208893005: Fix various inner classes now identified by the Blink GC plugin.

Issue 208893005: Fix various inner classes now identified by the Blink GC plugin. (Closed)

Created:
6 years, 9 months ago by zerny-chromium

Modified:
6 years, 9 months ago

Reviewers:
haraken, wibling-chromium

CC:
blink-reviews, kenneth.christiansen, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, oilpan-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix various inner classes now identified by the Blink GC plugin. R=wibling@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170033

Patch Set 2 : remove unneeded private: #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -16 lines)			Patch
M	Source/core/css/MediaQueryMatcher.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/css/MediaQueryMatcher.cpp	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.h	View	1	3 chunks	+2 lines, -5 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.cpp	View		1 chunk	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/208893005/diff/1/Source/core/css/MediaQueryMatcher.cpp File Source/core/css/MediaQueryMatcher.cpp (left): https://codereview.chromium.org/208893005/diff/1/Source/core/css/MediaQueryMatcher.cpp#oldcode40 Source/core/css/MediaQueryMatcher.cpp:40: MediaQueryMatcher::Listener::~Listener() Can we use DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED ?

6 years, 9 months ago (2014-03-25 14:21:34 UTC) #2

zerny-chromium

Thanks for the review. https://codereview.chromium.org/208893005/diff/1/Source/core/css/MediaQueryMatcher.cpp File Source/core/css/MediaQueryMatcher.cpp (left): https://codereview.chromium.org/208893005/diff/1/Source/core/css/MediaQueryMatcher.cpp#oldcode40 Source/core/css/MediaQueryMatcher.cpp:40: MediaQueryMatcher::Listener::~Listener() On 2014/03/25 14:21:34, haraken ...

6 years, 9 months ago (2014-03-26 07:40:37 UTC) #3

haraken

On 2014/03/26 07:40:37, zerny-chromium wrote: > Thanks for the review. > > https://codereview.chromium.org/208893005/diff/1/Source/core/css/MediaQueryMatcher.cpp > File ...

6 years, 9 months ago (2014-03-26 07:41:17 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/208893005/50002

6 years, 9 months ago (2014-03-26 08:03:44 UTC) #7

Message was sent while issue was closed.

Change committed as 170033

Expand Messages | Collapse Messages