Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 208893003: More distance field improvements (Closed)

Created:
6 years, 9 months ago by jvanverth1
Modified:
6 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

More distance field improvements: - Make sure we only use the 0,0 subpixel glyph - Copy image data into outsized buffer to ensure we capture outer edges - Change edge dump to blend better with original glyph - Edges are detected across >128 and <128 boundaries, or when there are two non-zero <128 pixels next to each other BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13916

Patch Set 1 #

Patch Set 2 : Add comments #

Total comments: 2

Patch Set 3 : Slightly faster clearing of temp glyph buffer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -13 lines) Patch
M src/core/SkDistanceFieldGen.cpp View 1 2 4 chunks +39 lines, -12 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jvanverth1
6 years, 9 months ago (2014-03-24 14:20:29 UTC) #1
robertphillips
lgtm https://codereview.chromium.org/208893003/diff/20001/src/core/SkDistanceFieldGen.cpp File src/core/SkDistanceFieldGen.cpp (right): https://codereview.chromium.org/208893003/diff/20001/src/core/SkDistanceFieldGen.cpp#newcode359 src/core/SkDistanceFieldGen.cpp:359: unsigned char* copyPtr = (unsigned char*) copyStorage.get(); Wouldn't ...
6 years, 9 months ago (2014-03-24 14:32:28 UTC) #2
jvanverth1
https://codereview.chromium.org/208893003/diff/20001/src/core/SkDistanceFieldGen.cpp File src/core/SkDistanceFieldGen.cpp (right): https://codereview.chromium.org/208893003/diff/20001/src/core/SkDistanceFieldGen.cpp#newcode359 src/core/SkDistanceFieldGen.cpp:359: unsigned char* copyPtr = (unsigned char*) copyStorage.get(); On 2014/03/24 ...
6 years, 9 months ago (2014-03-24 17:18:03 UTC) #3
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 9 months ago (2014-03-24 17:18:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/208893003/40001
6 years, 9 months ago (2014-03-24 17:18:12 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 18:34:07 UTC) #6
Message was sent while issue was closed.
Change committed as 13916

Powered by Google App Engine
This is Rietveld 408576698