Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2088903002: Fix flakiness in AccessibilityHighlightManagerTest and re-enable. (Closed)

Created:
4 years, 6 months ago by dmazzoni
Modified:
4 years, 6 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flakiness in AccessibilityHighlightManagerTest and re-enable. I ran these tests 10x on try servers with this change and saw no more flakiness. BUG=621306 Committed: https://crrev.com/81b4256b39ac2a3e8391aff4921599394f19fc19 Cr-Commit-Position: refs/heads/master@{#401104}

Patch Set 1 #

Total comments: 2

Patch Set 2 : AsBitmap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -14 lines) Patch
M chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc View 1 4 chunks +27 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dmazzoni
4 years, 6 months ago (2016-06-21 18:25:45 UTC) #2
xiyuan
https://codereview.chromium.org/2088903002/diff/1/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc File chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc (right): https://codereview.chromium.org/2088903002/diff/1/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc#newcode140 chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc:140: image_.AsBitmap().deepCopyTo(&bitmap); nit: Is this copy necessary? Can we just ...
4 years, 6 months ago (2016-06-21 19:19:37 UTC) #3
dmazzoni
https://codereview.chromium.org/2088903002/diff/1/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc File chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc (right): https://codereview.chromium.org/2088903002/diff/1/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc#newcode140 chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc:140: image_.AsBitmap().deepCopyTo(&bitmap); On 2016/06/21 19:19:37, xiyuan wrote: > nit: Is ...
4 years, 6 months ago (2016-06-21 19:59:06 UTC) #4
xiyuan
lgtm
4 years, 6 months ago (2016-06-21 20:00:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088903002/20001
4 years, 6 months ago (2016-06-21 20:21:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 20:58:28 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 21:00:06 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81b4256b39ac2a3e8391aff4921599394f19fc19
Cr-Commit-Position: refs/heads/master@{#401104}

Powered by Google App Engine
This is Rietveld 408576698