Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2088883002: Never use CPU-built mips for Gray_8. (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
Reviewers:
cblume, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Never use CPU-built mips for Gray_8. Fixes a bug where Gray_8 textures would still render as Alpha_8 (if the first draw was detected as needing mips). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2088883002 Committed: https://skia.googlesource.com/skia/+/7e5e594ea6fe0179b35e9d6ecb9d40cf0313f564

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/gpu/SkGr.cpp View 1 chunk +9 lines, -0 lines 1 comment Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088883002/1
4 years, 6 months ago (2016-06-21 17:55:46 UTC) #3
Brian Osman
4 years, 6 months ago (2016-06-21 17:56:30 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-21 18:13:26 UTC) #7
bsalomon
lgtm, but it would be nice to have a test. Maybe we can add a ...
4 years, 6 months ago (2016-06-21 18:57:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088883002/1
4 years, 6 months ago (2016-06-21 19:07:31 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 19:08:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7e5e594ea6fe0179b35e9d6ecb9d40cf0313f564

Powered by Google App Engine
This is Rietveld 408576698