Remove toolchain definition to build with gcc on Mac.

Remove toolchain definition to build with gcc on Mac.

Those toolchain definition are not used (and not working as building
with gcc on Mac does not currently work).

BUG=None

Committed: https://crrev.com/944038877a37801b29a42ae5fbca04963df14ae1
Cr-Commit-Position: refs/heads/master@{#401232}

[sdefresne, 2016-06-21 13:26:30]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org

[sdefresne, 2016-06-21 13:26:31]

Followup to https://codereview.chromium.org/2079283002/ to remove the toolchain
to build with gcc on Mac (unsupported currently).

PTAL.

[Dirk Pranke, 2016-06-21 16:31:34]

lgtm

[sdefresne, 2016-06-21 20:33:18]

https://codereview.chromium.org/2088823002/diff/20001/build/toolchain/mac/BUI...
File build/toolchain/mac/BUILD.gn (right):

https://codereview.chromium.org/2088823002/diff/20001/build/toolchain/mac/BUI...
build/toolchain/mac/BUILD.gn:363: cc = "${compiler_prefix}clang"
I noticed that cc/cxx/ld/is_clang are always the same in all invocation of the
mac_toolchain template. Should I instead inline them in the template? It would
avoid duplication but would make harder to support building with another
compiler on Mac/iOS (though it is currently unlikely to happen).

WDYT? Do you want me to update my CL?

[Dirk Pranke, 2016-06-21 21:24:50]

https://codereview.chromium.org/2088823002/diff/20001/build/toolchain/mac/BUI...
File build/toolchain/mac/BUILD.gn (right):

https://codereview.chromium.org/2088823002/diff/20001/build/toolchain/mac/BUI...
build/toolchain/mac/BUILD.gn:363: cc = "${compiler_prefix}clang"
On 2016/06/21 20:33:18, sdefresne wrote:
> I noticed that cc/cxx/ld/is_clang are always the same in all invocation of the
> mac_toolchain template. Should I instead inline them in the template? It would
> avoid duplication but would make harder to support building with another
> compiler on Mac/iOS (though it is currently unlikely to happen).
> 
> WDYT? Do you want me to update my CL?

It probably would be a good idea to inline them in the template just to make
things a bit clearer, but I won't be upset if you don't do that now.

[sdefresne, 2016-06-22 07:49:41]

Patchset #3 (id:40001) has been deleted

[sdefresne, 2016-06-22 08:26:00]

OK, I've moved the constant parameters into the template.

[sdefresne, 2016-06-22 08:26:05]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-06-22 08:26:05]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2088823002/#ps60001
(title: "Remove constant parameters to mac_toolchain template")

[commit-bot: I haz the power, 2016-06-22 08:26:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2088823002/60001

[commit-bot: I haz the power, 2016-06-22 08:46:44]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-06-22 08:48:21]

Description was changed from

==========
Remove toolchain definition to build with gcc on Mac.

Those toolchain definition are not used (and not working as building
with gcc on Mac does not currently work).

BUG=None
==========

to

==========
Remove toolchain definition to build with gcc on Mac.

Those toolchain definition are not used (and not working as building
with gcc on Mac does not currently work).

BUG=None

Committed: https://crrev.com/944038877a37801b29a42ae5fbca04963df14ae1
Cr-Commit-Position: refs/heads/master@{#401232}
==========

[commit-bot: I haz the power, 2016-06-22 08:48:22]

Patchset 3 (id:??) landed as
https://crrev.com/944038877a37801b29a42ae5fbca04963df14ae1
Cr-Commit-Position: refs/heads/master@{#401232}