content/browser/renderer_host/offscreen_canvas_surface_impl.cc - Issue 2088793003: Fix heap-use-after-free in cc::SurfaceManager::Destroy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/offscreen_canvas_surface_impl.cc

Issue 2088793003: Fix heap-use-after-free in cc::SurfaceManager::Destroy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/offscreen_canvas_surface_impl.cc

diff --git a/content/browser/renderer_host/offscreen_canvas_surface_impl.cc b/content/browser/renderer_host/offscreen_canvas_surface_impl.cc

index 417bf88d4f651e131171f784792741b92e6a5794..edbed1acad500d6efd8bbfec98f50754cfea202f 100644

--- a/content/browser/renderer_host/offscreen_canvas_surface_impl.cc

+++ b/content/browser/renderer_host/offscreen_canvas_surface_impl.cc

@@ -25,9 +25,6 @@ OffscreenCanvasSurfaceImpl::OffscreenCanvasSurfaceImpl(

binding_(this, std::move(request)) {}

OffscreenCanvasSurfaceImpl::~OffscreenCanvasSurfaceImpl() {

- if (surface_factory_) {

- surface_factory_->DestroyAll();

- }

}

void OffscreenCanvasSurfaceImpl::GetSurfaceId(

« no previous file with comments | « no previous file | no next file » | no next file with comments »