Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2088793003: Fix heap-use-after-free in cc::SurfaceManager::Destroy (Closed)

Created:
4 years, 6 months ago by xlai (Olivia)
Modified:
4 years, 6 months ago
Reviewers:
Justin Novosad, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix heap-use-after-free in cc::SurfaceManager::Destroy There is no need to call DestroyAll() on surface_factory_ inside OffscreenCanvasSurfaceImpl's destructor, because surface_factory_ is its unique pointer and SurfaceFactory's own destructor already contains DestroyAll(). TBR=piman@chromium.org BUG=621849 Committed: https://crrev.com/cfe3e0ebde0e9448cb5964373a6938afe229f397 Cr-Commit-Position: refs/heads/master@{#400994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M content/browser/renderer_host/offscreen_canvas_surface_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
xlai (Olivia)
4 years, 6 months ago (2016-06-21 14:18:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088793003/1
4 years, 6 months ago (2016-06-21 14:26:19 UTC) #5
piman
lgtm lgtm
4 years, 6 months ago (2016-06-21 15:04:43 UTC) #6
piman
lgtm
4 years, 6 months ago (2016-06-21 15:04:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 15:05:56 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 15:08:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfe3e0ebde0e9448cb5964373a6938afe229f397
Cr-Commit-Position: refs/heads/master@{#400994}

Powered by Google App Engine
This is Rietveld 408576698