Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1835)

Issue 2088793002: Revert of OpenURL post data handling. (Closed)

Created:
4 years, 6 months ago by oystein (OOO til 10th of July)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org, Charlie Reis
Base URL:
https://chromium.googlesource.com/chromium/src.git@post-data-my-stuff
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of OpenURL post data handling. (patchset #9 id:160001 of https://codereview.chromium.org/2004653002/ ) Reason for revert: Reverting due to https://bugs.chromium.org/p/chromium/issues/detail?id=621473 Original issue's description: > Passing ResourceRequestBody via FrameHostMsg_OpenURL_Params. > > This CL adds support for passing ResourceRequestBody (i.e. POST data) > inside the payload of FrameHostMsg_OpenURL IPC message. > > This CL adds |uses_post| and |resource_request_body| to > FrameHostMsg_OpenURL_Params and plumbs through these 2 values into > OpenURLParams passed to //content embedder. > > This CL wraps-up the work started in 2 earlier CLs: > > - https://crrev.com/2038813003 (Making ResourceRequestBody part of > //content's public API.) > > - https://crrev.com/2038233002 (Using ResourceRequestBody as the type of > HTTP body outside of //content) > > After this CL scenarios and tests that requires passing of POST data > via OpenURL code path should start working: > > - HTTP POST requests where decidePolicyForNavigation tells that the > request should be handled by the //content embedder. This scenario > is covered by a new CrossSiteTransferTest.PostViaOpenUrlMsg content > browser test added in this CL. > > - HTTP POST requests handled by RenderFrame::navigate (i.e. form > submissions targeting remote frame). This scenario is covered > by a layout test added in a recent CL: > http/tests/navigation/form-targets-cross-site-frame-post.html > > BUG=344348 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/bb2101b8d45775fef16a0ce4af1ae71f35749e76 > Cr-Commit-Position: refs/heads/master@{#400442} TBR=creis@chromium.org,nasko@chromium.org,dcheng@chromium.org,lukasza@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=344348

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -123 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 2 chunks +0 lines, -38 lines 0 comments Download
M content/browser/frame_host/navigator.h View 1 chunk +7 lines, -10 lines 0 comments Download
M content/browser/frame_host/navigator_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 2 chunks +7 lines, -12 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/security_exploit_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.h View 2 chunks +5 lines, -9 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 8 chunks +23 lines, -29 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 2 chunks +0 lines, -3 lines 0 comments Download
D content/test/data/form_that_posts_to_echoall.html View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
oystein (OOO til 10th of July)
Created Revert of OpenURL post data handling.
4 years, 6 months ago (2016-06-21 12:51:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088793002/1
4 years, 6 months ago (2016-06-21 12:51:33 UTC) #3
oystein (OOO til 10th of July)
4 years, 6 months ago (2016-06-21 12:54:44 UTC) #5
Please ignore this one; incorrect CL.

Powered by Google App Engine
This is Rietveld 408576698