Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2088763004: Remove resource_context.h include from resource_loader.cc. (Closed)

Created:
4 years, 6 months ago by jam
Modified:
4 years, 6 months ago
Reviewers:
scottmg
CC:
chromium-reviews, loading-reviews_chromium.org, darin-cc_chromium.org, jam, Randy Smith (Not in Mondays), mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove resource_context.h include from resource_loader.cc. Instead have it get the cert provider from its delegate (ResourceDispatcherHost) which in turn gets it from its delegate. The new method in ResourceDispatcherHostDelegate does use ResourceContext, but we are centralizing its use in just one class. In the future when the interface to resource dispatcher is mojo calls, we will have the child process' user ID which we can then use to get a profile interface for that user. BUG=598073 Committed: https://crrev.com/347b567048a1521fc2b4cf47bbbfd885eb70ec39 Cr-Commit-Position: refs/heads/master@{#401402}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -70 lines) Patch
M chrome/browser/profiles/profile_io_data.h View 1 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +29 lines, -32 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M content/browser/loader/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/loader/resource_loader_delegate.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/loader/resource_loader_unittest.cc View 1 6 chunks +12 lines, -20 lines 0 comments Download
M content/browser/resource_context_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M content/public/browser/resource_context.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/public/browser/resource_dispatcher_host_delegate.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/public/browser/resource_dispatcher_host_delegate.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
jam
4 years, 6 months ago (2016-06-22 19:49:11 UTC) #3
scottmg
lgtm
4 years, 6 months ago (2016-06-22 20:37:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088763004/40001
4 years, 6 months ago (2016-06-22 20:44:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-22 21:07:53 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 21:11:51 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/347b567048a1521fc2b4cf47bbbfd885eb70ec39
Cr-Commit-Position: refs/heads/master@{#401402}

Powered by Google App Engine
This is Rietveld 408576698