Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 2088733006: Deflake svg/custom/pointer-events-image*.svg (Closed)

Created:
4 years, 6 months ago by fs
Modified:
4 years, 6 months ago
Reviewers:
pdr.
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake svg/custom/pointer-events-image*.svg Rewrite these two tests (which are essentially the same, modulo a transform) to first wait for all the images to load, and then perform all the clicks. BUG=621915 Committed: https://crrev.com/14cf0aa6f21190351736e44ce017f18ae651c75c Cr-Commit-Position: refs/heads/master@{#401343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -107 lines) Patch
M third_party/WebKit/LayoutTests/svg/custom/pointer-events-image.svg View 2 chunks +69 lines, -53 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/pointer-events-image-css-transform.svg View 2 chunks +71 lines, -54 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
fs
*phuh*
4 years, 6 months ago (2016-06-22 17:12:09 UTC) #2
pdr.
Niiice, LGTM I wonder if we could emit a console warning at shutdown if there ...
4 years, 6 months ago (2016-06-22 17:17:36 UTC) #3
fs
On 2016/06/22 at 17:17:36, pdr wrote: > Niiice, LGTM > > I wonder if we ...
4 years, 6 months ago (2016-06-22 17:56:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088733006/1
4 years, 6 months ago (2016-06-22 17:57:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 18:09:12 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 18:12:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14cf0aa6f21190351736e44ce017f18ae651c75c
Cr-Commit-Position: refs/heads/master@{#401343}

Powered by Google App Engine
This is Rietveld 408576698