Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2088683002: Make StringKeyframe constructor take a const CSSValue (Closed)

Created:
4 years, 6 months ago by sashab
Modified:
4 years, 5 months ago
Reviewers:
dstockwell, Timothy Loh
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_make_csspropertyspecifickeyframe_take_const
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make StringKeyframe constructor store a const CSSValue Make StringKeyframe constructor take a const CSSValue. This is an entirely mechanical change and is pre-work to make CSSPropertyParser::addProperty() take a const CSSValue&. BUG=526586 Committed: https://crrev.com/27fa077909b2e3b6a247dfda019f9b9b88373fed Cr-Commit-Position: refs/heads/master@{#404046}

Patch Set 1 #

Patch Set 2 : Removed persistent storage to see effect on trybots. #

Patch Set 3 : Removed everything except value() method to see effect on trybots #

Patch Set 4 : Revert back to original patch to land - this should not change any behavior #

Patch Set 5 : Removed the persistent const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/Source/core/animation/StringKeyframe.h View 1 2 3 4 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
sashab
Timloh; please review, you LGTMd this before but I couldn't land it in that other ...
4 years, 5 months ago (2016-07-05 01:54:28 UTC) #2
sashab
Doug pls review, mechanical change
4 years, 5 months ago (2016-07-05 02:39:25 UTC) #4
dstockwell
lgtm
4 years, 5 months ago (2016-07-05 23:20:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2088683002/60001
4 years, 5 months ago (2016-07-05 23:24:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/187820)
4 years, 5 months ago (2016-07-06 02:10:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2088683002/80001
4 years, 5 months ago (2016-07-07 01:21:46 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-07-07 02:47:28 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 02:50:28 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/27fa077909b2e3b6a247dfda019f9b9b88373fed
Cr-Commit-Position: refs/heads/master@{#404046}

Powered by Google App Engine
This is Rietveld 408576698