Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2088663004: Adds PID to `server.connected` notification (#26744). (Closed)

Created:
4 years, 6 months ago by pquitslund
Modified:
4 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -8 lines) Patch
M pkg/analysis_server/doc/api.html View 3 chunks +6 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart View 7 chunks +29 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 2 chunks +5 lines, -1 line 2 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 6 months ago (2016-06-21 22:53:26 UTC) #2
Brian Wilkerson
With one change, lgtm https://codereview.chromium.org/2088663004/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/2088663004/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode243 pkg/analysis_server/tool/spec/spec_input.html:243: <ref>String</ref> I think we want ...
4 years, 6 months ago (2016-06-21 22:57:54 UTC) #3
pquitslund
Thanks! https://codereview.chromium.org/2088663004/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/2088663004/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode243 pkg/analysis_server/tool/spec/spec_input.html:243: <ref>String</ref> On 2016/06/21 22:57:54, Brian Wilkerson wrote: > ...
4 years, 6 months ago (2016-06-21 23:00:15 UTC) #4
pquitslund
4 years, 6 months ago (2016-06-21 23:00:34 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
270695fc31deebfb79f3ead111e84ad62c51a29a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698