Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 2088663002: [Extensions] Add perf metrics for StartRequest()/HandleResponse() (Closed)

Created:
4 years, 6 months ago by Devlin
Modified:
4 years, 6 months ago
Reviewers:
lazyboy, Mark P
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Add perf metrics for StartRequest()/HandleResponse() StartRequest() and HandleResponse() are used in the renderer to start and finish an extension function call. The most intensive part of this involves receiving arguments from v8 and converting them to base::Values (or vice versa). Add a timer to see how long this takes. Depending on the data, we may also want to break this into buckets and record the function enum to highlight particularly egregious functions, as we do for function execution time. BUG=608561 Committed: https://crrev.com/b2b31390d6845f42b5966f854e90f69ff39705e0 Cr-Commit-Position: refs/heads/master@{#401462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -12 lines) Patch
M extensions/renderer/request_sender.h View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/renderer/request_sender.cc View 7 chunks +12 lines, -4 lines 0 comments Download
M extensions/renderer/send_request_natives.cc View 3 chunks +15 lines, -7 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Devlin
One more for y'all. :)
4 years, 6 months ago (2016-06-21 01:24:43 UTC) #2
lazyboy
extensions lgtm.
4 years, 6 months ago (2016-06-21 02:23:02 UTC) #3
Mark P
histograms.xml lgtm
4 years, 6 months ago (2016-06-22 22:06:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088663002/1
4 years, 6 months ago (2016-06-22 22:27:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 23:39:33 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 23:43:32 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2b31390d6845f42b5966f854e90f69ff39705e0
Cr-Commit-Position: refs/heads/master@{#401462}

Powered by Google App Engine
This is Rietveld 408576698