Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2088653003: Remove SVN code from update_depot_tools (Closed)

Created:
4 years, 6 months ago by agable
Modified:
4 years, 6 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update version check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -88 lines) Patch
M update_depot_tools View 1 5 chunks +16 lines, -70 lines 0 comments Download
M update_depot_tools.bat View 3 chunks +4 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
agable
4 years, 6 months ago (2016-06-21 13:42:07 UTC) #1
M-A Ruel
agagaga ^^^ that's the sound of me having a hard time breathing due to excitement. ...
4 years, 6 months ago (2016-06-21 13:48:13 UTC) #2
agable
https://codereview.chromium.org/2088653003/diff/1/update_depot_tools File update_depot_tools (right): https://codereview.chromium.org/2088653003/diff/1/update_depot_tools#newcode74 update_depot_tools:74: if ((GITD[0] < 1 || (GITD[0] == 1 && ...
4 years, 6 months ago (2016-06-21 13:53:11 UTC) #3
M-A Ruel
lgtm
4 years, 6 months ago (2016-06-21 14:04:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088653003/20001
4 years, 6 months ago (2016-06-21 14:09:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/670)
4 years, 6 months ago (2016-06-21 14:11:44 UTC) #8
agable
On 2016/06/21 at 14:11:44, commit-bot wrote: > Try jobs failed on following builders: > Depot ...
4 years, 6 months ago (2016-06-21 14:14:46 UTC) #9
agable
4 years, 6 months ago (2016-06-21 14:22:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a0e5cc40f0ab6b75058956f268eac455da61ee19 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698