Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2088633003: X87: [stubs] ToNumberStub --> ToNumber builtin. (Closed)

Created:
4 years, 6 months ago by zhengxing.li
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [stubs] ToNumberStub --> ToNumber builtin. port 406146ff5ca274265ee704d73a00c8a8127f75c6(r36870) original commit message: This makes sure we do not compile ToNumber stub on demand. This makes it easier to use during concurrent compilation. BUG= Committed: https://crrev.com/f99c419b00aab3ba49c8a67e544c3fd954f0a03a Cr-Commit-Position: refs/heads/master@{#37125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 6 months ago (2016-06-21 02:11:18 UTC) #2
Weiliang
lgtm
4 years, 6 months ago (2016-06-21 03:01:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088633003/1
4 years, 6 months ago (2016-06-21 05:44:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 06:06:02 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 06:07:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f99c419b00aab3ba49c8a67e544c3fd954f0a03a
Cr-Commit-Position: refs/heads/master@{#37125}

Powered by Google App Engine
This is Rietveld 408576698